warnings from recent git pull

[Gary E. Miller]

Yo Hal!

On Thu, 25 May 2017 18:03:10 -0700
Hal Murray <hmurray at megapathdsl.net> wrote:

> > Fixes pushed, give it a try.  
> 
> Looks good, but some builds still in the pipeline and I'm about to
> leave. Assume OK unless I get back to you.

I'll watch buildbot.

> >> From Fedora and many/most other systems:  
> > Not 'most' from where I sit.  
> 
> Did you try tests/option-tester.sh?  A lot of that stuff doesn't
> happen unless you use the right configure options.

This was related to things waf detected about the OS, not to config
options.

> >> ../../tests/libparse/binio.c:130:23: warning: declaration of 'exp'
> >> shadows a global declaration  
> > As I suspected, a NetBSD name collision.  Fix pushed.  
> 
> OpenBSD gets the exp/shadow warnings.  So does an old CentOS.

Still?  I no longer see any 'exp' in binio.  Got the log output?

> I don't understand why it doesn't happen on all systems.

Because netBSD defines a macro called 'exp()', but Linux does not.

> ntp_fp.h
> includes math.h which defines exp.

Only in some OS.  And nothing that includes ntp_fp.h defines any
variable called exp.  Except for whatever one I missed.


> Is there some magic that drops
> that warning if you don't use the symbol from the header in some
> other part of the code being compiled?

#ifdef exp
# undef exp
#endif

But easiest just to not create a variable called exp.

> Maybe there were too many false positives like that one?

Huh?

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170525/cfa3b8ad/attachment.bin>