warnings from recent git pull

[Gary E. Miller]

Yo Hal!

On Thu, 25 May 2017 15:46:22 -0700
Hal Murray via devel <devel at ntpsec.org> wrote:

> From Fedora and many/most other systems:

Not 'most' from where I sit.  Fixes pushed, give it a try.

> test-all/test.log:../../ntpd/ntp_loopfilter.c:170:12: warning:
> ‘state’ defined but not used [-Wunused-variable]
> test-minimal/test.log:../../ntpd/ntp_loopfilter.c:160:13: warning: 
> ‘ext_enable’ defined but not used [-Wunused-variable]

As I suspected, the now file static variables needed to be in #ifdef's.
So they were always unused for you, you just did not know it.  Fix pushed.

> From netbsd:
> ../../tests/libparse/binio.c:130:23: warning: declaration of 'exp'
> shadows a global declaration

As I suspected, a NetBSD name collision.  Fix pushed.

> This chunk of code from start_kern_loop in loopfilter looks
> suspicious.

> #ifdef STA_NANO

No point using PPS direct to the kernel if it does not do nano seconds.

>                 if (pll_status & STA_CLK)
>                         ext_enable = true;

The ntp_adjtime() man page says:

       STA_CLK (read-only; since Linux 2.6.26)
              Clock source (0 = A, 1 = B); currently unused.

Looking at the kernel source, STA_CLK is read-only and never set.

What about NetBSD?

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170525/c2251e6b/attachment.bin>