warnings from recent git pull

[Gary E. Miller]

Yo Hal!

On Thu, 25 May 2017 15:46:22 -0700
Hal Murray via devel <devel at ntpsec.org> wrote:


> test-all/test.log:../../ntpd/ntp_loopfilter.c:170:12: warning: ‘state’ defined but not used [-Wunused-variable]
> test-minimal/test.log:../../ntpd/ntp_loopfilter.c:160:13: warning: ‘ext_enable’ defined but not used [-Wunused-variable]

I made those two variables file static.  Now your C compilter was able to
determine they were unused.  I'm guessing some #if are not in the right
place.  I'll fix that.

> From netbsd:
> ../../tests/libparse/binio.c:130:23: warning: declaration of 'exp'
> shadows a global declaration
> Why don't we get this on other platforms?

That is in some tests I just added.  It exposed (yet another) known 
but in NetBSD.  I know the fix, I'll push it today.

> We should also review the atexit stuff.  The system can crash or get
> kill-ed -9 without running the exit code.  What happens if it doesn't
> get run?

Dunno, I've not looked at that stuff.  My guess is it is mostly
good housekeeping.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170525/fd41e441/attachment.bin>