ntpkeygen patch

[Greg Rubin]

Very weird. Especially as I don't actually make changes which should cause
the errors you provided.

$ pyflakes ntpkeygen
$ pyflakes ntpkeygen.new
$ diff -u ntpkeygen ntpkeygen.new
--- ntpkeygen   2017-01-04 17:50:18.051264022 +0000
+++ ntpkeygen.new       2017-01-04 17:50:08.367264001 +0000
@@ -88,7 +88,7 @@
             print("usage: ntpkeygen [-M]")
             raise SystemExit(0)

-    randomizer = random.SystemRandom(time.time() + os.getpid())
+    randomizer = random.SystemRandom()
     gen_md5("md5", socket.gethostname())
     raise SystemExit(0)

$ python ntpkeygen
Generating new md5 file and link
ntp.keys->ntpkey_MD5key_u5065f31b3a9e57fbd471.1483567130
$ python ntpkeygen.new
Generating new md5 file and link
ntp.keys->ntpkey_MD5key_u5065f31b3a9e57fbd471.1483567132


Greg

On Wed, Jan 4, 2017 at 1:51 PM Gary E. Miller <gem at rellim.com> wrote:

> Yo Greg!
>
> On Wed, 4 Jan 2017 20:38:58 +0000
> "Rubin, Greg" <rubin at amazon.com> wrote:
>
> > Sending this from my work email. I've attached the diff to remove the
> > unneeded seeding logic.
>
> Here is a trivial way to see your patch is bad:
>
> spidey ~ # pyflakes ntpkeygen
> ntpkeygen:19: 'random' imported but unused
> ntpkeygen:38: undefined name 'randomizer'
> ntpkeygen:46: undefined name 'randomizer'
>
> We do not take patches that fail pyflakes.
>
> Please ponder the Zen of the pyflakes output before your next post.
>
> Please move this discussion to devel@ so the people that need to
> be in this discussion are in this discussion.
>
> RGDS                                                 Veritas liberabit vos
> GARY                                                     Quid est veritas?
> ---------------------------------------------------------------------------
> Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
> gem at rellim.com  Tel:+1 541 382 8588 <(541)%20382-8588>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170104/11c367b4/attachment.html>