<div dir="ltr">Very weird. Especially as I don't actually make changes which should cause the errors you provided.<br><br><div><div>$ pyflakes ntpkeygen</div><div>$ pyflakes ntpkeygen.new</div><div>$ diff -u ntpkeygen ntpkeygen.new</div><div>--- ntpkeygen 2017-01-04 17:50:18.051264022 +0000</div><div>+++ ntpkeygen.new 2017-01-04 17:50:08.367264001 +0000</div><div>@@ -88,7 +88,7 @@</div><div> print("usage: ntpkeygen [-M]")</div><div> raise SystemExit(0)</div><div><br></div><div>- randomizer = random.SystemRandom(time.time() + os.getpid())</div><div>+ randomizer = random.SystemRandom()</div><div> gen_md5("md5", socket.gethostname())</div><div> raise SystemExit(0)</div><div><br></div><div>$ python ntpkeygen</div><div>Generating new md5 file and link</div><div>ntp.keys->ntpkey_MD5key_u5065f31b3a9e57fbd471.1483567130</div><div>$ python ntpkeygen.new</div><div>Generating new md5 file and link</div><div>ntp.keys->ntpkey_MD5key_u5065f31b3a9e57fbd471.1483567132</div></div><div><br></div><div><br></div><div>Greg</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 4, 2017 at 1:51 PM Gary E. Miller <<a href="mailto:gem@rellim.com">gem@rellim.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yo Greg!<br class="gmail_msg">
<br class="gmail_msg">
On Wed, 4 Jan 2017 20:38:58 +0000<br class="gmail_msg">
"Rubin, Greg" <<a href="mailto:rubin@amazon.com" class="gmail_msg" target="_blank">rubin@amazon.com</a>> wrote:<br class="gmail_msg">
<br class="gmail_msg">
> Sending this from my work email. I've attached the diff to remove the<br class="gmail_msg">
> unneeded seeding logic.<br class="gmail_msg">
<br class="gmail_msg">
Here is a trivial way to see your patch is bad:<br class="gmail_msg">
<br class="gmail_msg">
spidey ~ # pyflakes ntpkeygen<br class="gmail_msg">
ntpkeygen:19: 'random' imported but unused<br class="gmail_msg">
ntpkeygen:38: undefined name 'randomizer'<br class="gmail_msg">
ntpkeygen:46: undefined name 'randomizer'<br class="gmail_msg">
<br class="gmail_msg">
We do not take patches that fail pyflakes.<br class="gmail_msg">
<br class="gmail_msg">
Please ponder the Zen of the pyflakes output before your next post.<br class="gmail_msg">
<br class="gmail_msg">
Please move this discussion to devel@ so the people that need to<br class="gmail_msg">
be in this discussion are in this discussion.<br class="gmail_msg">
<br class="gmail_msg">
RGDS Veritas liberabit vos<br class="gmail_msg">
GARY Quid est veritas?<br class="gmail_msg">
---------------------------------------------------------------------------<br class="gmail_msg">
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703<br class="gmail_msg">
<a href="mailto:gem@rellim.com" class="gmail_msg" target="_blank">gem@rellim.com</a> Tel:<a href="tel:(541)%20382-8588" value="+15413828588" class="gmail_msg" target="_blank">+1 541 382 8588</a><br class="gmail_msg">
</blockquote></div></div>