Lots of errors

Gary E. Miller gem at rellim.com
Fri Apr 14 19:26:54 UTC 2017

Yo Hal!

On Fri, 14 Apr 2017 11:59:56 -0700
Hal Murray <hmurray at megapathdsl.net> wrote:

> > Then how did you last commit, which failed to build with
> > --enable-debug slip through?  
> It used to be the default.  My setup hasn't yet recovered from that
> switch.

Yeah, it will take a while for everyone to catch up.

> Why didn't buildbot complain?

Because buildbot does not build with --enable-debug.

> > I test with both (usually) before pushing.  
> Is that a run time test, or just a build?
> We need more/better run time testing.

Patches welcome.

> > Only 50 more of those warnings to fix!  Some will be a bit nasty,
> > some can never be fixed, like the bugs in Bison and libisc.  
> I added tests/option-testing.sh to help find this sort of problem.
> We should teach buildbot to run it occasionally.  (but only if the
> output will include warnings)

Patches welcome.

> There are some grumbles about inlines from old CentOS and maybe
> others (NetBSD?)

> ../../include/timespecops.h:331: warning: inlining failed in call to 
> ‘tspec_stamp_to_lfp’: call is unlikely and code size would grow
> ../../ntpd/refclock_shm.c:555: warning: called from here
> ../../include/timespecops.h:331: warning: inlining failed in call to 
> ‘tspec_stamp_to_lfp’: call is unlikely and code size would grow
> ../../ntpd/refclock_shm.c:556: warning: called from here

Hmmm, not sure how to fix that one.  I'll ponder.

I see your email client is still not UTF-8.

> ../../ntpd/ntp_config.c:2955: warning: implicit declaration of
> function ‘yyparse’

This file is autogeneraed by Bison.  Upstream bug.  Good luck getting
that one fixed.

> I may have fixed (aka de-inlined) something similar in ntp_monitor
> before I figured out that the warning was probably bogus.

Not bogus at all.  It means we are telling the c compiler to do
something it refuses to do.  When the C compiler starts doing things the
programmer did not explicitly ask for that is worrisome.  Not horrible,
but needs to be fixed.

Which is why this warning is not shown with normal builds.

Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170414/33836767/attachment.bin>

More information about the devel mailing list