Another maxpoll mixup

Hal Murray hmurray at
Tue Sep 27 22:59:21 UTC 2016

> So, got any patch ideas?

Sorry, it will be obvious after you see it.

You are fixing up the default, and then immediately overwriting that store 
with a new value.

>         if (NTP_MAXPOLL_UNK == maxpoll)
>             /* not set yet, set to default */
>             peer->maxpoll = NTP_MAXDPOLL;
>         peer->maxpoll = max(maxpoll, NTP_MINPOLL);

Change the peer->maxpoll = NTP_MAXDPOLL
to maxpoll = NTP_MAXDPOLL

I haven't tried it yet, but that's clearly a bug.

These are my opinions.  I hate spam.

More information about the devel mailing list