Another maxpoll mixup
Gary E. Miller
gem at rellim.com
Tue Sep 27 23:08:12 UTC 2016
Yo Hal!
On Tue, 27 Sep 2016 15:59:21 -0700
Hal Murray <hmurray at megapathdsl.net> wrote:
> > So, got any patch ideas?
>
> Sorry, it will be obvious after you see it.
>
> You are fixing up the default, and then immediately overwriting that
> store with a new value.
>
> > if (NTP_MAXPOLL_UNK == maxpoll)
> > /* not set yet, set to default */
> > peer->maxpoll = NTP_MAXDPOLL;
> > peer->maxpoll = max(maxpoll, NTP_MINPOLL);
>
> Change the peer->maxpoll = NTP_MAXDPOLL
> to maxpoll = NTP_MAXDPOLL
>
> I haven't tried it yet, but that's clearly a bug.
Duh. Thanks for seeing that, and pointing it out. Fix pushed.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
gem at rellim.com Tel:+1 541 382 8588
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ntpsec.org/pipermail/devel/attachments/20160927/f6571d4b/attachment.bin>
More information about the devel
mailing list