Another maxpoll mixup

Gary E. Miller gem at rellim.com
Tue Sep 27 20:35:33 UTC 2016


Yo Hal!

On Tue, 27 Sep 2016 12:59:44 -0700
Hal Murray <hmurray at megapathdsl.net> wrote:

> gem at rellim.com said:
> > It it called newpeer() there would be no problem.  That function
> > tests for NTP_MAXPOLL_UNK and handles the case.   
> 
> Yes, but your code is buggy.
> 
> Here is your code (with a few lines omitted):
> 
>         if (NTP_MAXPOLL_UNK == maxpoll)
>             /* not set yet, set to default */
>             peer->maxpoll = NTP_MAXDPOLL;
>         peer->maxpoll = max(maxpoll, NTP_MINPOLL);


Yes, I know there is a bug, and I know that is from you patch (mostly),
and it still looks good to me.

So, got any patch ideas?

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ntpsec.org/pipermail/devel/attachments/20160927/2f9e262f/attachment.bin>


More information about the devel mailing list