Six not properly documented patches for ntpviz

[Richard Laager]

NAK on 0001-ntpviz-Make-some-conditionals-Yoda-style.patch and the 
similar part of the change in 
0001-ntpviz-correct-usaage-for-no-os.errno-ever.patch. That style is not 
common in Python, as it is unnecessary. Python does not allow "if x = 
y", so you cannot make the mistake that style prohibits (in C).


For 0001-ZZZ-ntp.ntpstats-ntpviz-change-refclock-name-punting.patch, I 
like that it expands coverage to other refclock types. I'm not sure 
where this is used, exactly, so I'm unsure about how I feel about the 
change from PPS(1) to pps(1).


For the rest, I'm prepared to merge them, if you can sanity check my 
small changes: https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1474

-- 
Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20250702/930c66d5/attachment.htm>