<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>NAK on 0001-ntpviz-Make-some-conditionals-Yoda-style.patch and
the similar part of the change in
0001-ntpviz-correct-usaage-for-no-os.errno-ever.patch. That style
is not common in Python, as it is unnecessary. Python does not
allow "if x = y", so you cannot make the mistake that style
prohibits (in C).</p>
<p><br>
</p>
<p>For
0001-ZZZ-ntp.ntpstats-ntpviz-change-refclock-name-punting.patch, I
like that it expands coverage to other refclock types. I'm not
sure where this is used, exactly, so I'm unsure about how I feel
about the change from PPS(1) to pps(1).</p>
<p><br>
</p>
<p>For the rest, I'm prepared to merge them, if you can sanity check
my small changes:
<a class="moz-txt-link-freetext" href="https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1474">https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1474</a><br>
</p>
<pre class="moz-signature" cols="72">--
Richard</pre>
</body>
</html>