New Defects reported by Coverity Scan for ntpsec

[Hal Murray]

I took a look at the Coverity reports for ntpsec.
There are 10 of them.  10 is a small number.  We should be able to fix them 
all.

The Coverity report that started this thread was actually a bug.

The code I had was
   bool once = false;
   if (once) return;
   once = true;
   ...

I was so focused on getting the compiler warnings (-Wswitch-enum) that I 
missed the missing static on once.


-- 
These are my opinions.  I hate spam.