Release

[James Browning]

> On 12/17/2023 9:49 PM PST Hal Murray via devel <devel at ntpsec.org> wrote:
>  
> Fred Wright said:

:::snip:::

> > There are also a bunch of warnings with some compilers, which might be  worth
> > looking at.  They're often fairly easy to fix, and sometimes indicate actual
> > problems. 
> 
> Which compilers?  Or rather which OS/distros?
> 
> Can we set things up so that the gitlab CI stuff tells us about warnings?
> 
> James suggested adding the compiler flag that turns warnings into errors.  
> That won't work on the old old version of Bison that has a missing default or 
> something like that.

I also would be interested in seeing these errors for myself.

there is also 'clang -Weverything' and some weblinks
- https://gitlab.com/NTPsec/ntpsec/-/security/vulnerability_report
- https://app.codacy.com/gl/NTPsec/ntpsec/dashboard
- https://scan8.scan.coverity.com/#/project-view/50864/11242

I am also attaching a file derived from the output of clang.
A previous attempt to send a more complete listing had issues.
-------------- next part --------------
-Weverything (x86_64 Linux Clang 16)
1889 -Wunsafe-buffer-usage
1382 -Wpadded
 375 -Wextra-semi-stmt
 167 -Wdouble-promotion
 103 -Wsign-conversion
  81 -Wshorten-64-to-32
  65 -Wimplicit-int-conversion
  58 -Wmissing-variable-declarations
  56 -Wdeclaration-after-statement
  53 -Wunused-macros
  52 -Wimplicit-int-float-conversion
  32 -Wcovered-switch-default
  23 -Wimplicit-float-conversion
  20 -Wdisabled-macro-expansion
  17 -Wformat-nonliteral
  16 -Wunreachable-code-break
  14 -Wunreachable-code
  12 -Wfloat-conversion
  10 -Wcast-align
   8 -Wimplicit-fallthrough
   5 -Wcast-function-type-strict
   5 -Wbad-function-cast
   4 -Wused-but-marked-unused
   4 -Wreserved-identifier
   2 -Wextra-semi
   2 -Wconditional-uninitialized
   2 -Wcomma
   1 -Wunreachable-code-return
   1 -Wstring-conversion
   1 -Wreserved-macro-identifier


-Weverything (arm64 macOS clang 15)
1310 -Wpadded
 404 -Wunused-macros
 158 -Wpoison-system-directories
  99 -Wsign-conversion
  82 -Wshorten-64-to-32
  57 -Wmissing-variable-declarations
  54 -Wdeclaration-after-statement
  52 -Wimplicit-int-conversion
  28 -Wcovered-switch-default
  22 -Wcast-align
  17 -Wformat-nonliteral
  16 -Wunreachable-code
  13 -Wunreachable-code-break
   8 -Wimplicit-float-conversion
   6 -Wdouble-promotion
   5 -Wbad-function-cast
   4 -Wused-but-marked-unused
   3 -Wfloat-conversion
   2 -Wextra-semi
   2 -Wdisabled-macro-expansion
   2 -Wconditional-uninitialized
   1 -Wunreachable-code-return
   1 -Wstring-conversion