Release

[Matthew Selsky]

On Sun, Dec 17, 2023 at 08:17:23PM -0800, Fred Wright via devel wrote:

Hi Fred,

> The main issue I've found is that the "struct var" in ntp_control.c, is
> relying on anonymous unions, which are a relatively new language feature.
> They were originally a GNU extension, eventually becoming official in C11.
> But significantly increasing the compiler requirements just for one table
> doesn't seem terribly desirable.

Should our use of "-std=c99" have caught this?  Or is that flag not intended to catch features newer than standard X?

> There are also a bunch of warnings with some compilers, which might be worth
> looking at.  They're often fairly easy to fix, and sometimes indicate actual
> problems.

Do you have specifics on distros/compilers that are showing warnings so we can run these to ground?

> I also stumbled across something (which may not be new) where it appears
> that if libaes_siv is installed as a system library, it's preferred over the
> bundled version.  That probably doesn't change the actual behavior, but may
> lead to opportunistic builds.

Interesting. Which distro includes libaes_siv as a system library?  We don't modify libaes_siv so using the system version should be fine.


Cheers,
-Matt