New compile warnings...

[Gary E. Miller]

Yo Hal!

On Tue, 02 Nov 2021 21:15:25 -0700
Hal Murray <halmurray at sonic.net> wrote:

> Looks like a compiler bug to me.  But that's just a quick look.

BUg or not, gcc should compile NTPsec.

> Are you using some non-standard compiler options?

Dunno, I'll test.ZZ

./waf -vvv configure --enable-debug --enable-debug-gdb --enable-warnings --refclock=all --enable-doc  && ./waf build  && ./waf install

>  Does it get the
> same errors on a different architecture?

Nope.

> The first one is in libntp/authkeys.c so I should be familiar with
> that code.
> 
> It's complaining about the second line in this pair:
>                 auth->digest = NULL;
>                 auth->cipher = NULL;
> by saying:
>   warning: dereference of NULL \u2018auth\u2019

Odd.

> There are a whole bunch of other references to auth->xxx above, so I
> think it should have complained much earlier.

UNless cipher is also a pointer.

> This looks fushy too:
>   warning: leak of FILE \u2018farg\u2019
> It gets closed a couple of layers up.

Prolly why it is complaining there.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20211102/7f006b47/attachment.bin>