Buggy WNRO fixup

[Gary E. Miller]

Yo Hal!

On Wed, 29 Dec 2021 13:31:44 -0800
Hal Murray via devel <devel at ntpsec.org> wrote:

> Gary said:
> >> The code I was expecting doesn't know anything about leaps.
> >> It would be close to:
> >>   while (t < PIVOT) t += 1024*7*86400  
> 
> > Which will break after 1024 weeks. Which sounds like a lot, but
> > there are a lot of GPS that are more than 1024 weeks old since
> > their firmware was cut.  
> 
> Your code has similar problems.  Right?

Only a few of the problematic drivers have the problem.  As lone as the
NMEA reports the correct year, all is good.

> That's 1024 weeks after ntpsec is released.  I'm willing to assume
> that ntpsec gets updated more often than that.

Not 100%, but close.

> We could add a config option to sepcify the pivot date but that
> doesn't seem worth the effort.

Maybe for testing, but anyone using a 1024 week old ntpd will not have read
the man page in a long time.

> Do we have any place to collect documentation for quirks like this?

Prolly best in the NMEA doc.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20211229/6ced9a96/attachment.bin>