Is anyone else having trouble running ntpviz w/ 1 gps? (w/ patch)

James Browning jamesb.fe80 at gmail.com
Tue Oct 6 13:29:40 UTC 2020


So, I was running ntpviz rarely, I updated to a (recentish git head), I
added a gpsd module symlink under ntpclients/, and boom breakage. I
followed the traceback to a line, I patched the line a couple of times, and
I requested the following patch. Was anyone else running into this?
Also, one of the dicts in that file (probably same commit) should be an
ordered dict, as the summary lines are now alphabetized. I will get to that
soon.

>From a0e5847f22929657699fc6eea7e4b72c89a27a1a Mon Sep 17 00:00:00 2001
From: James Browning <jamesb.fe80 at gmail.com>
Date: Mon, 5 Oct 2020 14:17:00 -0700
Subject: [PATCH] ntpviz: Revise in the aftermath of changes ...

'Experimental cleanups for lgtm. No logic changes'
appears to have bent the instances of running with
one GPS on Python 2.7 and 3.8 on Ubuntu ARM.
---
 ntpclients/ntpviz.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ntpclients/ntpviz.py b/ntpclients/ntpviz.py
index c30e35509..7b5c32aed 100644
--- a/ntpclients/ntpviz.py
+++ b/ntpclients/ntpviz.py
@@ -793,7 +793,7 @@ plot \\
             plot_template += """\
 '-' using 1:2 title '%s TDOP' with line ls 1, \\
 '-' using 1:3 title '%s nSat' with line ls 2 axis x1y2, \\
-""" % (key,)
+""" % (key,key)

         # strip the trailing ", \\n"
         plot_template = plot_template[:-4] + "\n"
-- 
2.25.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20201006/61c46564/attachment.htm>


More information about the devel mailing list