no ssl.h on macos?

[Matthew Selsky]

On Sat, Feb 09, 2019 at 05:28:16AM -0800, Hal Murray via devel wrote:
> I thought we got farther than this last night.
> 
> Does macos have OpenSSL?  What version?
> 
> Stage: build
> Name: macos-basic
> Trace: ../../include/nts.h:7:10: fatal error: 'openssl/ssl.h' file not found
> #include <openssl/ssl.h>
>          ^~~~~~~~~~~~~~~
> 1 error generated.

https://gitlab.com/NTPsec/ntpsec/-/jobs/158846691 makes the error a bit more clear:

[2/2] Compiling build/host/ntpd/ntp_parser.tab.c
In file included from /Users/gitlab-runner/builds/FrHjVgVw/0/NTPsec/ntpsec/ntpd/ntp_parser.y:16:
In file included from ../../include/ntp.h:17:
../../include/nts.h:7:10: fatal error: 'openssl/ssl.h' file not found
#include <openssl/ssl.h>
         ^~~~~~~~~~~~~~~
1 error generated.

The parser generator includes ntp.h.  ntp.h was recently changed to include nts.h.  And nts.h needs openssl/ssl.h

So we either need to add "SSL" to the "use" flag for the parser builder (not that the parser actually needs OpenSSL), or we change the chaining of the include files so that the parser doesn't have a transitive dependency on openssl/ssl.h

My intuition is that the latter is the correct long-term answer, but I'm not sure how to appropriately re-arrange the header inclusions.


Thanks,
-Matt