ntpsec | WIP: Strerror (!1027)

[Hal Murray]

Richard Laager said:
> This is an untested (beyond building cleanly) patch for cleaning up the strerror_r() API issue.

What environment did you use?

I get several warnings on Fedora.

--------

../../libntp/isc_net.c: In function ‘try_proto’:
../../libntp/isc_net.c:56:4: warning: implicit declaration of function 
‘ntp_strerror_r’; did you mean ‘strerror_r’? 
[-Wimplicit-function-declaration]
   56 |    ntp_strerror_r(errno, strbuf, sizeof(strbuf));
      |    ^~~~~~~~~~~~~~
      |    strerror_r

---

../../libaes_siv/aes_siv.c:5: warning: "_POSIX_C_SOURCE" redefined
    5 | #define _POSIX_C_SOURCE 200112L
      |
<command-line>: note: this is the location of the previous definition

In file included from /usr/include/python2.7/pyconfig.h:6,
                 from /usr/include/python2.7/Python.h:8,
                 from ../../libntp/pymodule.c:7:
/usr/include/python2.7/pyconfig-64.h:1229: warning: "_POSIX_C_SOURCE" redefined
 1229 | #define _POSIX_C_SOURCE 200112L
      | 
<command-line>: note: this is the location of the previous definition
In file included from /usr/include/python2.7/pyconfig.h:6,
                 from /usr/include/python2.7/Python.h:8,
                 from ../../libntp/pymodule.c:7:
/usr/include/python2.7/pyconfig-64.h:1251: warning: "_XOPEN_SOURCE" redefined
 1251 | #define _XOPEN_SOURCE 600
      |
<command-line>: note: this is the location of the previous definition

-----

../../ntpd/refclock_gpsd.c:67: warning: "_XOPEN_SOURCE" redefined
   67 | #define _XOPEN_SOURCE 600
      |
<command-line>: note: this is the location of the previous definition


-- 
These are my opinions.  I hate spam.