gitlab heads-up: approval feature enabled for MRs

Richard Laager rlaager at
Wed May 23 05:01:51 UTC 2018

On 05/22/2018 11:28 PM, Hal Murray via devel wrote:
> What are the advantagesof a merge request if the submitter has write access?

The code gets run by continuous integration (CI), if the project has CI
(which this one does).

The commit gets review from at least a second person before it is
merged. Code review generally improves code quality.

In my experience, the fact that code review will happen encourages
developers to be more strict in their own self-review.

It adds a bit of delay. If you catch a mistake shortly after pushing,
you've only pushed it to the MR, not trunk, so you can fix it there.


More information about the devel mailing list