Heads up - eyeballs needed

Hal Murray hmurray at megapathdsl.net
Thu Mar 16 08:54:28 UTC 2017


There is a release coming soon.

Gary just made a large collection of editing changes that shouldn't change 
the code.  The compiler checks the syntax but can't catch typos that do 
things like a sign reversal in the exponent of a constant.

I noticed one typo.  See below.  It would be very good if people could check 
the changes.  There might be others.  I think just scanning git log -p is a 
good approach.  Most of the changes are tiny so the diff will be 2 lines plus 
context.

I also made a large change to the leap second code.  I've tested that it 
doesn't do anything stupid when there isn't a leap scheduled.  It will take 
some work to verify that a leap second actually leaps correctly.  At least we 
have time until the next possible leap.  It may be easier to scan the code 
rather than the diffs.

----------

Do we have any tools that diff compiler output?  I want to compare the code, 
ignoring symbols and time stamps.  It would

----------

>From include/timespecops.h
#define S_PER_NS 1.0e-9

--- a/ntpd/refclock_generic.c
+++ b/ntpd/refclock_generic.c
@@ -19,6 +19,7 @@
 
-                                                       dtemp = (double) 
pts.tv_nsec / 1e9;
+                                                       dtemp = (double) 
pts.tv_nsec * S_PER_NS;

It's got several friends.  It's late enough that I didn't try to fix 
anything.  How about we funnel the fixes through Gary to avoid duplicates and 
thrashing.



-- 
These are my opinions.  I hate spam.





More information about the devel mailing list