lfpinit() signed or unsigned?

Eric S. Raymond esr at thyrsus.com
Thu Mar 9 19:35:20 UTC 2017


Gary E. Miller <gem at rellim.com>:
> It gets worse.  Looks like l_fp needs to be int64_t, not uint64_t.
> Sometimes l_fp's are subtracted to get an offset.

It doesn't matter.  All those calculations are casted to within an inch of
their lives. :-)

> And weird things happen in lfp_intv_to_tspec() to guess if l_fp is
> unsigned or signed...

Yes, they do.  I inherited that logic.

Be very, very careful about changing any of this stuff. I got it to where
it is by a series of provably behavior-preserving steps from the old code.
The corner cases are tricky.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Please consider contributing to my Patreon page at https://www.patreon.com/esr
so I can keep the invisible wheels of the Internet turning. Give generously -
the civilization you save might be your own.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: not available
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170309/1bc8a93b/attachment.bin>


More information about the devel mailing list