[Git][NTPsec/ntpsec][master] Replace "uint" with "unsigned int"

Gary E. Miller gem at rellim.com
Sat Jun 10 02:06:56 UTC 2017

Yo Matthew!

On Fri, 9 Jun 2017 21:31:51 -0400
Matthew Selsky via devel <devel at ntpsec.org> wrote:

> I used "unsigned int" so that I would match the typedef that I was
> replacing exactly.

Ah, repeating the mistakes of the past, faithfully.

> The codebase is not consistent about usage of "unsigned" vs "unsigned
> int".

What is consistent in the codebase?

> I'd be happy to search-and-replace everything to be consistent
> if we have consensus on which form we prefer.  

Yeah, much better, and less intrusive things to work on.  I prefer
that code updates like this only happen when you are already working
in that code area.

> Though the time might
> be better spent on changing to uintX :-)

That could be a big chore.  Most system functions want int or unsigned,
so when you go to uintX you gotta add a ton of casts...

Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170609/1e68f419/attachment.bin>

More information about the devel mailing list