[Bug] 1361811cb botches unused macro
Achim Gratz
Stromeko at nexgo.de
Sun Feb 19 12:50:16 UTC 2017
While hunting for changes that might have affected the DCF driver I've
come across this gem:
--8<---------------cut here---------------start------------->8---
@@ -433,7 +433,13 @@ struct peer {
#define CRYPTO_TO_ZERO(p) ((char *)&((p)->clear_to_zero))
#define END_CRYPTO_TO_ZERO(p) ((char *)&((p)->end_clear_to_zero))
#define LEN_CRYPTO_TO_ZERO (END_CRYPTO_TO_ZERO((struct peer *)0) \
- - CRYPTO_TO_ZERO((struct peer *)0))
+
+/*
+ * It's ugly that refid is sometimes treated as a uint32_t and sometimes
+ * as a string; that should be fixed. Using this in memcpy() at least
+ * contains the problem.
+ */
+#define REFIDLEN sizeof(uint32_t)
#define LEN_PKT_NOMAC 48 /* min header length */
--8<---------------cut here---------------end--------------->8---
Luckily the macro isn't used anywhere, so it's not been doing any harm.
In fact, all three CRYPTO macros are unused and can be eliminated.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
More information about the devel
mailing list