Matthew.Selsky at twosigma.com
Thu Dec 21 19:51:07 UTC 2017
On Wed, Dec 20, 2017 at 02:50:55PM -0800, Gary E. Miller via devel wrote:
> Yo Matthew!
> On Tue, 19 Dec 2017 23:05:37 -0500
> Matthew Selsky via devel <devel at ntpsec.org> wrote:
> > > If dev with merge-approver power pushes to a branch and then merges
> > > it, how is the entailed risk any different from a direct push?
> > We can have gitlab enforce that all CI builds must pass before
> > merge. This will keep some of the brokenness that we've seen in the
> > past out of master.
> Sadly, CI sometimes just randomly fails, for no known reason.
> As seen yesterday.
Yes, it sometimes fails. MR !617 marks the codequality job as "allow_failure: true" so that we don't fail the entire pipeline on Docker/CI bugginess.
But none of this is a reason to avoid using the CI system to help us keep master reasonable clean.
More information about the devel