HEAD broken if -u ntp:ntp

Hal Murray hmurray at megapathdsl.net
Fri Apr 14 11:18:16 UTC 2017


It crashes with 
Apr 14 04:00:30 fed ntpd[4726]: invalid op: 110

110 decimal is ascii u

This looks suspicious, but I'm sacking out.

commit d9ead3aa6abd718d4cf73bcf8023d312d510359e
Author: Gary E. Miller <gem at rellim.com>
Date:   Thu Apr 13 18:36:24 2017 -0700

    ntpd; add missing default case, fix a bad exit() code.

...

            case 'Z':
                if (ntp_optarg != NULL)
                        set_sys_var(ntp_optarg, strlen(ntp_optarg) + 1, 
(u_short) (RW | DEF));
-               break;
+                break;
+            default:
+               msyslog(LOG_ERR, "invalid op: %d", op);
+               exit(1);
            }
        }

-------

There are two loops scanning the command line args.


-- 
These are my opinions.  I hate spam.





More information about the devel mailing list