<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<h3 style="margin-top: 20px; margin-bottom: 10px;">
Matt Selsky pushed to branch master at <a href="https://gitlab.com/NTPsec/ntpsec">NTPsec / ntpsec</a>
</h3>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Commits:
</h4>
<ul>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.com/NTPsec/ntpsec/-/commit/26d04264f736a958be2ae0e1e04c95ad20ed5327">26d04264</a></strong>
<div>
<span> by Matt Selsky </span> <i> at 2026-10-05T14:45:19-04:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #f7f7f5; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdbd9;'>ntpd/nts_extens.c: enforce RFC 8915 minimum Unique_Identifier length
RFC 8915 5.3 says the Unique Identifier "MUST be at least 32 octets long".
extens_server_recv() only checked the upper bound, NTS_UID_MAX_LENGTH (the size
of its buffer), so a UID as short as 0 bytes was accepted.
The UID is opaque data that is echoed back, so this is a protocol conformance
fix, not a memory safety one. Clients may send UIDs longer than 32 octets, so
the server checks a range rather than an exact length.
</pre>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
1 changed file:
</h4>
<ul>
<li class="file-stats">
<a href="#1ff99aae534a910fa3ddd2012b99973e25e83a3a">
ntpd/nts_extens.c
</a>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Changes:
</h4>
<li id="1ff99aae534a910fa3ddd2012b99973e25e83a3a">
<a href="https://gitlab.com/NTPsec/ntpsec/-/commit/26d04264f736a958be2ae0e1e04c95ad20ed5327#1ff99aae534a910fa3ddd2012b99973e25e83a3a"><strong style="font-weight: 600;">ntpd/nts_extens.c</strong></a>
<hr style="overflow: hidden; border: 1px solid #dcdbd9;">
<table class="code white" style="border-spacing: 0; border-collapse: collapse; width: auto; font-family: monospace; font-size: 90%;" bgcolor="#ffffff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="153" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="153" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">...</td>
<td class="line_content match" style="color: rgba(5,5,6,.24); padding: inherit;" bgcolor="#f7f7f5">@@ -153,7 +153,7 @@ bool extens_server_recv(struct ntspacket_t *ntspacket, uint8_t *pkt, int lng) {</td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="153" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
153
</td>
<td class="new_line diff-line-num" data-linenumber="153" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
153
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdbd9;'> <span class="line" data-lang="c"> <span class="p">}</span></span>
</pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="154" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
154
</td>
<td class="new_line diff-line-num" data-linenumber="154" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
154
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdbd9;'> <span class="line" data-lang="c"> <span class="k" style="font-weight: 600;">switch</span> <span class="p">(</span><span class="n" style="color: #333333;">type</span><span class="p">)</span> <span class="p">{</span></span>
</pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="155" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
155
</td>
<td class="new_line diff-line-num" data-linenumber="155" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
155
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdbd9;'> <span class="line" data-lang="c"> <span class="k" style="font-weight: 600;">case</span> <span class="n" style="color: #333333;">Unique_Identifier</span><span class="p">:</span></span>
</pre></td>
</tr>
<tr class="line_holder old" style="line-height: 1.6;">
<td class="old_line diff-line-num old" data-linenumber="156" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f9d7dc">
156
</td>
<td class="new_line diff-line-num old" data-linenumber="156" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding: inherit;" bgcolor="#fbe9eb"><pre style='display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdbd9;'>-<span class="line" data-lang="c"> <span class="k" style="font-weight: 600;">if</span> <span class="p">(</span><span class="n" style="color: #333333;">length</span> <span class="o" style="font-weight: 600;">></span> <span class="n" style="color: #333333;">NTS_UID_MAX_LENGTH</span><span class="p">)</span> <span class="p">{</span></span>
</pre></td>
</tr>
<tr class="line_holder new" style="line-height: 1.6;">
<td class="old_line diff-line-num new" data-linenumber="157" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: inherit;" align="right" bgcolor="#ddfbe6">
</td>
<td class="new_line diff-line-num new" data-linenumber="156" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: inherit;" align="right" bgcolor="#ddfbe6">
156
</td>
<td class="line_content new" style="padding: inherit;" bgcolor="#ecfdf0"><pre style='display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdbd9;'>+<span class="line" data-lang="c"> <span class="k" style="font-weight: 600;">if</span> <span class="p">(</span><span class="n" style="color: #333333;">length</span> <span class="o" style="font-weight: 600;">></span> <span class="n" style="color: #333333;">NTS_UID_MAX_LENGTH</span><span class="idiff left addition" style="background-color: #c7f0d2;"> </span><span class="o" style="font-weight: 600;"><span class="idiff addition" style="background-color: #c7f0d2;">||</span></span><span class="idiff addition" style="background-color: #c7f0d2;"> </span><span class="n" style="color: #333333;"><span class="idiff addition" style="background-color: #c7f0d2;">length</span></span><span class="idiff addition" style="background-color: #c7f0d2;"> </span><span class="o" style="font-weight: 600;"><span class="idiff addition" style="background-color: #c7f0d2;"><</span></span><span class="idiff addition" style="background-color: #c7f0d2;"> </span><span class="n" style="color: #333333;"><span class="idiff right addition" style="background-color: #c7f0d2;">NTS_UID_LENGTH</span></span><span class="p">)</span> <span class="p">{</span></span>
</pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="157" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
157
</td>
<td class="new_line diff-line-num" data-linenumber="157" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
157
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdbd9;'> <span class="line" data-lang="c"> <span class="k" style="font-weight: 600;">return</span> <span class="nb" style="color: #0086b3;">false</span><span class="p">;</span></span>
</pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="158" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
158
</td>
<td class="new_line diff-line-num" data-linenumber="158" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
158
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdbd9;'> <span class="line" data-lang="c"> <span class="p">}</span></span>
</pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="159" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
159
</td>
<td class="new_line diff-line-num" data-linenumber="159" style="width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-color: #ecebea; border-right-style: solid; padding: inherit;" align="right" bgcolor="#f7f7f5">
159
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; font-size: 14px; color: #3a383d; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdbd9;'> <span class="line" data-lang="c"> <span class="n" style="color: #333333;">ntspacket</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333333;">uidlen</span> <span class="o" style="font-weight: 600;">=</span> <span class="n" style="color: #333333;">length</span><span class="p">;</span></span>
</pre></td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #646163;">
—
<br>
<a href="https://gitlab.com/NTPsec/ntpsec/-/commit/26d04264f736a958be2ae0e1e04c95ad20ed5327">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">Notification message regarding https://gitlab.com/NTPsec/ntpsec/-/commit/26d04264f736a958be2ae0e1e04c95ad20ed5327 at 64a33e84085edc2612834961e2021104</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.com/NTPsec/ntpsec/-/commit/26d04264f736a958be2ae0e1e04c95ad20ed5327"}}</script>
</p>
</div>
</body>
</html>