<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Hal Murray pushed to branch master
at <a href="https://gitlab.com/NTPsec/ntpsec">NTPsec / ntpsec</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/b525ad6ad1172ac462aa7a8e69fa3a2b78c9a044">b525ad6a</a></strong>
<div>
<span>by Matt Selsky</span>
<i>at 2019-03-14T04:48:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Make sure to include config.h in tests/ntpd/nts.c
Otherwise header files are included without our local symbols that control which other symbols are exposed
In this case, the result of trying to build on macOS was:
In file included from ../../tests/ntpd/nts.c:1:
In file included from ../../include/ntpd.h:13:
In file included from ../../include/ntp.h:15:
../../include/ntp_stdlib.h:135:15: error: expected parameter declarator
extern size_t strlcpy(char *dst, const char *src, size_t siz);
^
/usr/include/secure/_string.h:108:47: note: expanded from macro 'strlcpy'
__builtin___strlcpy_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
/usr/include/secure/_common.h:39:62: note: expanded from macro '__darwin_obsz'
^
/usr/include/secure/_common.h:30:32: note: expanded from macro '_USE_FORTIFY_LEVEL'
^
In file included from ../../tests/ntpd/nts.c:1:
In file included from ../../include/ntpd.h:13:
In file included from ../../include/ntp.h:15:
../../include/ntp_stdlib.h:135:15: error: expected ')'
/usr/include/secure/_string.h:108:47: note: expanded from macro 'strlcpy'
__builtin___strlcpy_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
/usr/include/secure/_common.h:39:62: note: expanded from macro '__darwin_obsz'
^
/usr/include/secure/_common.h:30:32: note: expanded from macro '_USE_FORTIFY_LEVEL'
^
../../include/ntp_stdlib.h:135:15: note: to match this '('
/usr/include/secure/_string.h:108:47: note: expanded from macro 'strlcpy'
__builtin___strlcpy_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
/usr/include/secure/_common.h:39:53: note: expanded from macro '__darwin_obsz'
^
In file included from ../../tests/ntpd/nts.c:1:
In file included from ../../include/ntpd.h:13:
In file included from ../../include/ntp.h:15:
../../include/ntp_stdlib.h:135:15: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
extern size_t strlcpy(char *dst, const char *src, size_t siz);
^
/usr/include/secure/_string.h:108:47: note: expanded from macro 'strlcpy'
__builtin___strlcpy_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
/usr/include/secure/_common.h:39:31: note: expanded from macro '__darwin_obsz'
^
In file included from ../../tests/ntpd/nts.c:1:
In file included from ../../include/ntpd.h:13:
In file included from ../../include/ntp.h:15:
../../include/ntp_stdlib.h:135:15: error: conflicting types for '__builtin___strlcpy_chk'
/usr/include/secure/_string.h:108:3: note: expanded from macro 'strlcpy'
__builtin___strlcpy_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
../../include/ntp_stdlib.h:135:15: note: '__builtin___strlcpy_chk' is a builtin with type 'unsigned long (char *, const char *, unsigned long, unsigned long)'
/usr/include/secure/_string.h:108:3: note: expanded from macro 'strlcpy'
__builtin___strlcpy_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
In file included from ../../tests/ntpd/nts.c:1:
In file included from ../../include/ntpd.h:13:
In file included from ../../include/ntp.h:15:
../../include/ntp_stdlib.h:145:15: error: expected parameter declarator
extern size_t strlcat(char *dst, const char *src, size_t siz);
^
/usr/include/secure/_string.h:115:47: note: expanded from macro 'strlcat'
__builtin___strlcat_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
/usr/include/secure/_common.h:39:62: note: expanded from macro '__darwin_obsz'
^
/usr/include/secure/_common.h:30:32: note: expanded from macro '_USE_FORTIFY_LEVEL'
^
In file included from ../../tests/ntpd/nts.c:1:
In file included from ../../include/ntpd.h:13:
In file included from ../../include/ntp.h:15:
../../include/ntp_stdlib.h:145:15: error: expected ')'
/usr/include/secure/_string.h:115:47: note: expanded from macro 'strlcat'
__builtin___strlcat_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
/usr/include/secure/_common.h:39:62: note: expanded from macro '__darwin_obsz'
^
/usr/include/secure/_common.h:30:32: note: expanded from macro '_USE_FORTIFY_LEVEL'
^
../../include/ntp_stdlib.h:145:15: note: to match this '('
/usr/include/secure/_string.h:115:47: note: expanded from macro 'strlcat'
__builtin___strlcat_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
/usr/include/secure/_common.h:39:53: note: expanded from macro '__darwin_obsz'
^
In file included from ../../tests/ntpd/nts.c:1:
In file included from ../../include/ntpd.h:13:
In file included from ../../include/ntp.h:15:
../../include/ntp_stdlib.h:145:15: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
extern size_t strlcat(char *dst, const char *src, size_t siz);
^
/usr/include/secure/_string.h:115:47: note: expanded from macro 'strlcat'
__builtin___strlcat_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
/usr/include/secure/_common.h:39:31: note: expanded from macro '__darwin_obsz'
^
In file included from ../../tests/ntpd/nts.c:1:
In file included from ../../include/ntpd.h:13:
In file included from ../../include/ntp.h:15:
../../include/ntp_stdlib.h:145:15: error: conflicting types for '__builtin___strlcat_chk'
/usr/include/secure/_string.h:115:3: note: expanded from macro 'strlcat'
__builtin___strlcat_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
../../include/ntp_stdlib.h:145:15: note: '__builtin___strlcat_chk' is a builtin with type 'unsigned long (char *, const char *, unsigned long, unsigned long)'
/usr/include/secure/_string.h:115:3: note: expanded from macro 'strlcat'
__builtin___strlcat_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
^
2 warnings and 6 errors generated.
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#426faa1ceb126a54a0f9487c0eb5968d60897434">
tests/ntpd/nts.c
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="426faa1ceb126a54a0f9487c0eb5968d60897434">
<a href="https://gitlab.com/NTPsec/ntpsec/commit/b525ad6ad1172ac462aa7a8e69fa3a2b78c9a044#426faa1ceb126a54a0f9487c0eb5968d60897434"><strong>tests/ntpd/nts.c</strong></a>
<hr>
<table class="code white" style="font-family: monospace; font-size: 90%;" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="1" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
1
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC1" class="line" lang="c"><span class="cp" style="color: #999; font-weight: 600;">#include "config.h"</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1
</td>
<td class="diff-line-num new_line" data-linenumber="2" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2" class="line" lang="c"><span class="cp" style="color: #999; font-weight: 600;">#include "ntpd.h"</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2
</td>
<td class="diff-line-num new_line" data-linenumber="3" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
3
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC3" class="line" lang="c"><span class="cp" style="color: #999; font-weight: 600;">#include "nts.h"</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="3" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
3
</td>
<td class="diff-line-num new_line" data-linenumber="4" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
4
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC4" class="line" lang="c"><span class="cp" style="color: #999; font-weight: 600;">#include "nts2.h"</span></span>
</pre>
</td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://gitlab.com/NTPsec/ntpsec/commit/b525ad6ad1172ac462aa7a8e69fa3a2b78c9a044">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.com/NTPsec/ntpsec/commit/b525ad6ad1172ac462aa7a8e69fa3a2b78c9a044"}}</script>
</p>
</div>
</body>
</html>