<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
</head>
<body>
<style type="text/css">
img {
max-width: 100%; height: auto;
}
</style>
<div class="content">
<h3>
Eric S. Raymond pushed to branch master
at <a href="https://gitlab.com/NTPsec/ntpsec">NTPsec / ntpsec</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/a97861b41d00349386f506d9d3ab3682aa6d98a8">a97861b4</a></strong>
<div>
<span>by Eric S. Raymond</span>
<i>at 2017-02-11T08:31:03-05:00</i>
</div>
<pre class="commit-message" style="margin: 0; white-space: pre-wrap">Add a pedantic overrun check that should never actually fire.
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#f51a036db06fd9a4adefe7467861c393fdc9a52a">
ntpd/refclock_magnavox.c
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="f51a036db06fd9a4adefe7467861c393fdc9a52a">
<a href="https://gitlab.com/NTPsec/ntpsec/commit/a97861b41d00349386f506d9d3ab3682aa6d98a8#f51a036db06fd9a4adefe7467861c393fdc9a52a"><strong>ntpd/refclock_magnavox.c</strong></a>
<hr>
<table class="code white" style="-premailer-cellpadding: 0; -premailer-cellspacing: 0; -premailer-width: 100%; background: #fff; font-family: monospace; font-size: 12px" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" style="line-height: 1.6">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="1578" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="1578" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="background: #fafafa; color: rgba(0,0,0,0.3); padding-left: 0.5em; padding-right: 0.5em" bgcolor="#fafafa">@@ -1578,7 +1578,9 @@ mx4200_send(struct peer *peer, char *fmt, ...)</td>
</tr>
<tr class="line_holder" style="line-height: 1.6">
<td class="diff-line-num old_line" data-linenumber="1578" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1578
</td>
<td class="diff-line-num new_line" data-linenumber="1578" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1578
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC1578" class="line"> <span class="n" style="color: #333">ck</span> <span class="o" style="font-weight: bold">=</span> <span class="n" style="color: #333">mx4200_cksum</span><span class="p">(</span><span class="n" style="color: #333">cp</span><span class="p">,</span> <span class="n" style="color: #333">n</span><span class="p">);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.6">
<td class="diff-line-num old_line" data-linenumber="1579" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1579
</td>
<td class="diff-line-num new_line" data-linenumber="1579" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1579
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC1579" class="line"> <span class="n" style="color: #333">cp</span> <span class="o" style="font-weight: bold">+=</span> <span class="n" style="color: #333">n</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.6">
<td class="diff-line-num old_line" data-linenumber="1580" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1580
</td>
<td class="diff-line-num new_line" data-linenumber="1580" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1580
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC1580" class="line"> <span class="o" style="font-weight: bold">++</span><span class="n" style="color: #333">n</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" style="line-height: 1.6">
<td class="diff-line-num old old_line" data-linenumber="1581" style="background: #f9d7dc; border-right-color: #fac5cd; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#f9d7dc">
1581
</td>
<td class="diff-line-num new_line old" data-linenumber="1581" style="background: #f9d7dc; border-right-color: #fac5cd; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="background: #fbe9eb; padding-left: 0.5em; padding-right: 0.5em" bgcolor="#fbe9eb">
<pre style="margin: 0">-<span id="LC1581" class="line"> <span class="n" style="color: #333">n</span> <span class="o" style="font-weight: bold">+=</span> <span class="n" style="color: #333">snprintf</span><span class="p">(</span><span class="n" style="color: #333">cp</span><span class="p">,</span> <span class="k" style="font-weight: bold">sizeof</span><span class="p">(</span><span class="n" style="color: #333">buf</span><span class="p">)</span> <span class="o" style="font-weight: bold">-</span> <span class="n" style="color: #333">n</span> <span class="o" style="font-weight: bold">-</span> <span class="mi" style="color: #099">5</span><span class="p">,</span> <span class="s" style="color: #d14">"*%02X</span><span class="se" style="color: #d14">\r\n</span><span class="s" style="color: #d14">"</span><span class="p">,</span> <span class="n" style="color: #333">ck</span><span class="p">);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" style="line-height: 1.6">
<td class="diff-line-num new old_line" data-linenumber="1582" style="background: #ddfbe6; border-right-color: #c7f0d2; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1581" style="background: #ddfbe6; border-right-color: #c7f0d2; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#ddfbe6">
1581
</td>
<td class="line_content new noteable_line" style="background: #ecfdf0; padding-left: 0.5em; padding-right: 0.5em" bgcolor="#ecfdf0">
<pre style="margin: 0">+<span id="LC1581" class="line"> <span class="cm" style="color: #998; font-style: italic">/* should always fire, it's only here to make overrun impossible */</span> </span>
</pre>
</td>
</tr>
<tr class="line_holder new" style="line-height: 1.6">
<td class="diff-line-num new old_line" data-linenumber="1582" style="background: #ddfbe6; border-right-color: #c7f0d2; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1582" style="background: #ddfbe6; border-right-color: #c7f0d2; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#ddfbe6">
1582
</td>
<td class="line_content new noteable_line" style="background: #ecfdf0; padding-left: 0.5em; padding-right: 0.5em" bgcolor="#ecfdf0">
<pre style="margin: 0">+<span id="LC1582" class="line"> <span class="k" style="font-weight: bold">if</span> <span class="p">(</span><span class="k" style="font-weight: bold">sizeof</span><span class="p">(</span><span class="n" style="color: #333">buf</span><span class="p">)</span> <span class="o" style="font-weight: bold">-</span> <span class="n" style="color: #333">n</span> <span class="o" style="font-weight: bold">>=</span> <span class="mi" style="color: #099">5</span><span class="p">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" style="line-height: 1.6">
<td class="diff-line-num new old_line" data-linenumber="1582" style="background: #ddfbe6; border-right-color: #c7f0d2; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1583" style="background: #ddfbe6; border-right-color: #c7f0d2; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#ddfbe6">
1583
</td>
<td class="line_content new noteable_line" style="background: #ecfdf0; padding-left: 0.5em; padding-right: 0.5em" bgcolor="#ecfdf0">
<pre style="margin: 0">+<span id="LC1583" class="line"> <span class="n" style="color: #333">n</span> <span class="o" style="font-weight: bold">+=</span> <span class="n" style="color: #333">snprintf</span><span class="p">(</span><span class="n" style="color: #333">cp</span><span class="p">,</span> <span class="k" style="font-weight: bold">sizeof</span><span class="p">(</span><span class="n" style="color: #333">buf</span><span class="p">)</span> <span class="o" style="font-weight: bold">-</span> <span class="n" style="color: #333">n</span> <span class="o" style="font-weight: bold">-</span> <span class="mi" style="color: #099">5</span><span class="p">,</span> <span class="s" style="color: #d14">"*%02X</span><span class="se" style="color: #d14">\r\n</span><span class="s" style="color: #d14">"</span><span class="p">,</span> <span class="n" style="color: #333">ck</span><span class="p">);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.6">
<td class="diff-line-num old_line" data-linenumber="1582" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1582
</td>
<td class="diff-line-num new_line" data-linenumber="1584" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1584
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC1584" class="line"></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.6">
<td class="diff-line-num old_line" data-linenumber="1583" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1583
</td>
<td class="diff-line-num new_line" data-linenumber="1585" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1585
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC1585" class="line"> <span class="n" style="color: #333">m</span> <span class="o" style="font-weight: bold">=</span> <span class="n" style="color: #333">write</span><span class="p">(</span><span class="n" style="color: #333">pp</span><span class="o" style="font-weight: bold">-></span><span class="n" style="color: #333">io</span><span class="p">.</span><span class="n" style="color: #333">fd</span><span class="p">,</span> <span class="n" style="color: #333">buf</span><span class="p">,</span> <span class="p">(</span><span class="kt" style="color: #458; font-weight: bold">unsigned</span><span class="p">)</span><span class="n" style="color: #333">n</span><span class="p">);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.6">
<td class="diff-line-num old_line" data-linenumber="1584" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1584
</td>
<td class="diff-line-num new_line" data-linenumber="1586" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
1586
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC1586" class="line"> <span class="k" style="font-weight: bold">if</span> <span class="p">(</span><span class="n" style="color: #333">m</span> <span class="o" style="font-weight: bold"><</span> <span class="mi" style="color: #099">0</span><span class="p">)</span></span>
</pre>
</td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px">
<p style="color: #777; font-size: small">
—
<br>
<a href="https://gitlab.com/NTPsec/ntpsec/commit/a97861b41d00349386f506d9d3ab3682aa6d98a8">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.com/NTPsec/ntpsec/commit/a97861b41d00349386f506d9d3ab3682aa6d98a8"}}</script>
</p>
</div>
</body>
</html>