[Git][NTPsec/ntpsec][master] ntpd/nts_client.c: correct the FIXME on the aead option

Matt Selsky (@selsky) gitlab at mg.gitlab.com
Tue Nov 10 02:27:45 UTC 2026



Matt Selsky pushed to branch master at NTPsec / ntpsec


Commits:
f6220fb0 by Matt Selsky at 2026-11-09T21:14:12-05:00
ntpd/nts_client.c: correct the FIXME on the aead option

nts_string_to_aead() matches the whole option string. so a
colon-separated list matches no algorithm and the client fails back to
the global or default AEAD. The comment said only the first entry was
offered.

- - - - -


1 changed file:

- ntpd/nts_client.c


Changes:

=====================================
ntpd/nts_client.c
=====================================
@@ -677,8 +677,8 @@ bool nts_client_send_request(SSL *ssl, struct peer* peer) {
 static uint16_t nts_client_aead(const struct peer *peer) {
         uint16_t aead = NO_AEAD;
 
-        // FIXME: the aead option should accept a colon-separated list of
-        // algorithms; only the first is offered
+        // FIXME: the aead option takes one algorithm name; it should
+        // accept a colon-separated list
         if (NULL != peer->cfg.nts_cfg.aead) {
                 aead = nts_string_to_aead(peer->cfg.nts_cfg.aead);
         }



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/-/commit/f6220fb00fb3db01cbc2f4e2779bc786d1b4c0ff

-- 
View it on GitLab: https://gitlab.com/NTPsec/ntpsec/-/commit/f6220fb00fb3db01cbc2f4e2779bc786d1b4c0ff
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/vc/attachments/20261110/04bc8dc2/attachment.htm>


More information about the vc mailing list