[Git][NTPsec/ntpsec][master] 3 commits: Add ntpq defaulting to AES

[Hal Murray (@hal.murray)]

Hal Murray pushed to branch master at NTPsec / ntpsec


Commits:
f8513096 by Hal Murray at 2023-12-07T00:10:45-08:00
Add ntpq defaulting to AES

- - - - -
9dc9606b by Hal Murray at 2023-12-07T00:10:45-08:00
Attempt to fix coverity 316495

- - - - -
fbcbd33d by Hal Murray at 2023-12-07T00:10:45-08:00
More tweaks to ntpd/ntp_filegen.c

  1) fix brain-fart in previous edit
  2) merge 2 cases
  3) squish warning for signed/unsigned compare

- - - - -


3 changed files:

- NEWS.adoc
- ntpd/ntp_filegen.c
- ntpd/ntp_scanner.c


Changes:

=====================================
NEWS.adoc
=====================================
@@ -18,6 +18,9 @@ on user-visible changes.
 * ntpd and ntpq both treat SHA-1 as an alias for SHA1
   NIST uses SHA-1.  The crypto package from OpenSSL uses SHA1.
 
+* The default crypto type for ntpq is now AES.
+  RFC 8573 deprecated MD5.
+
 * There are now log files with hourly statistics for NTS and
   NTS-KE traffic: filegen ntsstats and filegen ntskestats,
 


=====================================
ntpd/ntp_filegen.c
=====================================
@@ -338,17 +338,14 @@ filegen_setup(
 
 	default:
 	case FILEGEN_NONE:
-		current = true;
-		break;
-
 	case FILEGEN_PID:
-		current = false;
+		current = true;
 		break;
 
 	case FILEGEN_AGE:
 		/* current_time doesn't go backwards
 		 * so don't need to check id_lo */
-		current = (gen->id_hi > current_time);
+		current = ((unsigned)gen->id_hi > current_time);
 		break;
 
 	case FILEGEN_DAY:


=====================================
ntpd/ntp_scanner.c
=====================================
@@ -182,6 +182,7 @@ lex_getch(
 			conf_file_sum += (unsigned int)ch;
 	} else if (stream->fpi) {
 		/* fetch next 7-bit ASCII char (or EOF) from file */
+		/* coverity[tainted_scalar] */
 		while ((ch = fgetc(stream->fpi)) != EOF && ch > SCHAR_MAX) {
 			stream->curpos.ncol++;
 		}



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/-/compare/e3afd66839d79d6d0073d33b19b69ea0bf5ba58b...fbcbd33d23a9703749c9d3a6bb859b42f0a56e6e

-- 
View it on GitLab: https://gitlab.com/NTPsec/ntpsec/-/compare/e3afd66839d79d6d0073d33b19b69ea0bf5ba58b...fbcbd33d23a9703749c9d3a6bb859b42f0a56e6e
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/vc/attachments/20231207/effbc499/attachment-0001.htm>