[Git][NTPsec/ntpsec][master] Prevent lossage on garbage cookie count.

Eric S. Raymond gitlab at mg.gitlab.com
Thu Feb 21 04:32:41 UTC 2019


Eric S. Raymond pushed to branch master at NTPsec / ntpsec


Commits:
aa0c45d6 by Eric S. Raymond at 2019-02-21T04:32:26Z
Prevent lossage on garbage cookie count.

- - - - -


1 changed file:

- pylib/util.py


Changes:

=====================================
pylib/util.py
=====================================
@@ -1109,8 +1109,10 @@ class PeerSummary:
                 ptype = 'p'     # pool
             elif srcadr.startswith("224."):
                 ptype = 'a'     # manycastclient (compatibility with Classic)
-            elif ntscookies != 0:
-                ptype = str(ntscookies)
+            # FIXME: We're getting garbage value for the cookie count
+            #elif ntscookies != 0:
+            #    # FIXME: Will foo up if there are ever more than 9 cookies
+            #    ptype = chr(ntscookies + ord('0'))
             else:
                 ptype = 'u'     # unicast
         elif hmode == ntp.magic.MODE_ACTIVE:



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/aa0c45d6a2506103d784a2aa3684047c27531f28

-- 
View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/aa0c45d6a2506103d784a2aa3684047c27531f28
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/vc/attachments/20190221/c53cc856/attachment-0001.html>


More information about the vc mailing list