[Git][NTPsec/ntpsec][master] Abandon -Wsign-conversion, it's too flaky to be useful.

[Eric S. Raymond]

Eric S. Raymond pushed to branch master at NTPsec / ntpsec


Commits:
abf676d7 by Eric S. Raymond at 2017-09-07T11:22:47-04:00
Abandon -Wsign-conversion, it's too flaky to be useful.

- - - - -


2 changed files:

- ntpd/ntp_io.c
- wscript


Changes:

=====================================
ntpd/ntp_io.c
=====================================
--- a/ntpd/ntp_io.c
+++ b/ntpd/ntp_io.c
@@ -3281,9 +3281,7 @@ process_routing_msgs(struct asyncio_reader *reader)
 	 */
 #ifdef HAVE_LINUX_RTNETLINK_H
 	for (nh = (struct nlmsghdr *)buffer;
-	     /* Avoid a sign comparison warning on some Linux distributions */
 	     NLMSG_OK(nh, (unsigned) cnt);
-#pragma GCC diagnostic ignored "-Wsign-conversion"
 	     nh = NLMSG_NEXT(nh, cnt)) {
 		msg_type = nh->nlmsg_type;
 #else


=====================================
wscript
=====================================
--- a/wscript
+++ b/wscript
@@ -394,10 +394,11 @@ def configure(ctx):
         ] + ctx.env.CFLAGS
         cc_test_flags += [
             ('w_implicit_fallthru', "-Wimplicit-fallthrough=3"),
-            # fails on Solaris and OpenBSD 6
-            # complains about a Bison bug
-            ('w_sign_conversion', "-Wsign-conversion"),
-            # fails on clang, lot's of false positives and Unity complaints
+            # Fails on Solaris, OpenBSD 6, and RasPi
+            # Complains about a Bison bug
+            # Cannot be suppressed
+            # ('w_sign_conversion', "-Wsign-conversion"),
+            # fails on clang, lots of false positives and Unity complaints
             # ('w_suggest_attribute_const', "-Wsuggest-attribute=const"),
             # fails on clang, lot's of false positives and Unity complaints
             # ('w_suggest_attribute_pure', "-Wsuggest-attribute=pure"),



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/abf676d72f43da788405aa1701fd04bf5cec2c4e

---
View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/abf676d72f43da788405aa1701fd04bf5cec2c4e
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/vc/attachments/20170907/eea7a87d/attachment.html>