[Git][NTPsec/ntpsec][master] libisc: another try at Coverity CID 164518

[Gary E. Miller]

Gary E. Miller pushed to branch master at NTPsec / ntpsec


Commits:
c3869fe5 by Gary E. Miller at 2017-06-06T16:05:44-07:00
libisc: another try at Coverity CID 164518

I missed a return path.

- - - - -


1 changed file:

- libisc/error.c


Changes:

=====================================
libisc/error.c
=====================================
--- a/libisc/error.c
+++ b/libisc/error.c
@@ -25,11 +25,11 @@ isc_error_unexpected(const char *file, int line, const char *format, ...) {
         char errbuf[256];
         static int unexpected_error_cnt = 0;
 
-        va_start(args, format);
-
         if (unexpected_error_cnt >= MAX_UNEXPECTED_ERRORS)
                 return; /* avoid clutter in log */
 
+        va_start(args, format);
+
         msyslog(LOG_ERR, "%s:%d: unexpected error:", file, line);
         vsnprintf(errbuf, sizeof(errbuf), format, args);
         msyslog(LOG_ERR, "%s", errbuf);



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/c3869fe513715f070562bcfb1a68910facab8a32

---
View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/c3869fe513715f070562bcfb1a68910facab8a32
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/vc/attachments/20170606/2ec167db/attachment.html>