[Git][NTPsec/ntpsec][dgb-trace] 17 commits: assert: remove indirection by *isc_assertion_failed.

[Ian Bruene]

Ian Bruene pushed to branch dgb-trace at NTPsec / ntpsec


Commits:
aaa57b33 by Gary E. Miller at 2017-06-02T14:03:48-07:00
assert: remove indirection by *isc_assertion_failed.

ntpd only ever installed one assertion handler.  Before that pointer was
installed at runtime the assertions did not work well.  So remove all the
added indirection and just use assertion_failed().

Had to move assertion_failed() to libisc/assert.c to get it to work.

- - - - -
eb46eb45 by Gary E. Miller at 2017-06-02T14:24:32-07:00
assert: remove now unused isc_assertioncallback_t stuff.

Now that the assertion handler is hard coded, the stuff to
change the assertion handler can go away.  Which shows up
yet more unused code.

- - - - -
a040a1fd by Gary E. Miller at 2017-06-02T14:29:52-07:00
assert: remove default_callback().

It was only used until assertion_failed() was installed early in
startup.  Probably never worked, did not use mysyslog().

- - - - -
64ea95e0 by Gary E. Miller at 2017-06-02T14:32:48-07:00
assert: remove unused BACKTRACE_MAXFRAME

It was never used since the backtrace handlers were not installed.

- - - - -
b7a9dd68 by Gary E. Miller at 2017-06-02T14:35:30-07:00
assert: remove now unused prototype of isc_assertion_failed()

- - - - -
24dbf418 by Gary E. Miller at 2017-06-02T14:37:29-07:00
assert: make isc_assertion_typetotext() static.

- - - - -
3e314c9a by Gary E. Miller at 2017-06-02T14:39:47-07:00
assert: remove isc_ prefixes.

Not really ISC code anymore, does not look like their current code,
will keep their copyright.

- - - - -
d6034c4a by Gary E. Miller at 2017-06-02T14:43:18-07:00
assert: move libisc/assertions.c to libntp/assert.c

Not really ISC code anymore.

- - - - -
cb80377c by Gary E. Miller at 2017-06-02T14:48:38-07:00
assert: replace DEBUG_INSIST() with INSIST().

It was only used one place.  Also change DEBUG_ENSURE()
and DEBUG_REQUIRE(), which were all commented out anyway.

- - - - -
39d1c297 by Ian Bruene at 2017-06-02T18:01:36-05:00
Changed current debugging macros to DPRINT or TPRINT

- - - - -
306e407a by Ian Bruene at 2017-06-02T18:01:36-05:00
Swapped out explicit debug tests for macros

Debugging logs that are merely printfs have been replaced by
DPRINT / TPRINT, as appropriate. More complicated loggers have been
marked with SPECIAL DEBUG to aid in filtering.

- - - - -
6dc62964 by Ian Bruene at 2017-06-02T18:01:36-05:00
Fixing borked merge

- - - - -
77d33b60 by Ian Bruene at 2017-06-02T18:01:36-05:00
Fixed missing includes

- - - - -
79a3b436 by Ian Bruene at 2017-06-02T18:01:36-05:00
Typo

- - - - -
de1f0e57 by Ian Bruene at 2017-06-02T18:01:36-05:00
Typo (again)

- - - - -
4cdb048e by Ian Bruene at 2017-06-02T18:01:36-05:00
Borked merge fix

- - - - -
846e062b by Ian Bruene at 2017-06-02T18:01:36-05:00
Fixed refclock_generic.c, hopefully

- - - - -


30 changed files:

- include/ntp_assert.h
- include/ntp_debug.h
- include/ntpd.h
- libisc/wscript
- libisc/assertions.c → libntp/assert.c
- libntp/authkeys.c
- libntp/clockwork.c
- libntp/msyslog.c
- libntp/socket.c
- libntp/statestr.c
- libntp/timetoa.c
- libntp/wscript
- libparse/ieee754io.c
- ntpd/ntp_config.c
- ntpd/ntp_control.c
- ntpd/ntp_filegen.c
- ntpd/ntp_io.c
- ntpd/ntp_loopfilter.c
- ntpd/ntp_monitor.c
- ntpd/ntp_packetstamp.c
- ntpd/ntp_peer.c
- ntpd/ntp_proto.c
- ntpd/ntp_refclock.c
- ntpd/ntp_restrict.c
- ntpd/ntp_scanner.c
- ntpd/ntp_signd.c
- ntpd/ntp_timer.c
- ntpd/ntp_util.c
- ntpd/ntpd.c
- ntpd/refclock_arbiter.c


The diff was not included because it is too large.


View it on GitLab: https://gitlab.com/NTPsec/ntpsec/compare/7ead8ea3a479473037dbfd93b37fe4f3a20ab04e...846e062bf0d0b3fc4af4b64e3a191c0623af46b4

---
View it on GitLab: https://gitlab.com/NTPsec/ntpsec/compare/7ead8ea3a479473037dbfd93b37fe4f3a20ab04e...846e062bf0d0b3fc4af4b64e3a191c0623af46b4
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/vc/attachments/20170602/190b410e/attachment.html>