[Git][NTPsec/ntpsec][master] Comment polishing.

[Eric S. Raymond]

Eric S. Raymond pushed to branch master at NTPsec / ntpsec


Commits:
7e4f35d0 by Eric S. Raymond at 2017-08-22T20:28:17-04:00
Comment polishing.

- - - - -


6 changed files:

- ntpd/ntp_config.c
- ntpd/ntp_io.c
- ntpd/ntp_peer.c
- ntpd/ntpd.c
- ntpd/refclock_oncore.c
- pylib/packet.py


Changes:

=====================================
ntpd/ntp_config.c
=====================================
--- a/ntpd/ntp_config.c
+++ b/ntpd/ntp_config.c
@@ -35,14 +35,14 @@
 #include "ntp_dns.h"
 
 /*
- * [Bug 467]: Some linux headers collide with CONFIG_PHONE and CONFIG_KEYS
- * so #include these later.
+ * [Classic Bug 467]: Some linux headers collide with CONFIG_PHONE and
+ * CONFIG_KEYS so #include these later.
  */
 #include "ntp_config.h"
 #include "ntp_scanner.h"
 #include "ntp_parser.tab.h"
 
-/* Hack to dance around bug in older Bison.  See Issue 287 */
+/* Hack to dance around bug in older Bison.  See Classic Issue 287 */
 /* Similar for yydebug below */
 #ifndef yyparse
   int yyparse (void);
@@ -90,9 +90,9 @@ char **	cmdline_servers;
 
 /*
  * FIXME: ugly globals, only created to avoid wiring in option-parsing cruft.
- * These are symptoms of deeper factoring issues; the things they're controlling,
- * deep down inside that configuration parsing, should not be happening where
- * they are.
+ * These are symptoms of deeper factoring issues; the things they're
+ * controlling, deep down inside that configuration parsing, should
+ * not be happening where they are.
  */
 bool have_interface_option;
 


=====================================
ntpd/ntp_io.c
=====================================
--- a/ntpd/ntp_io.c
+++ b/ntpd/ntp_io.c
@@ -2358,7 +2358,7 @@ read_network_packet(
 	 */
 
 	/*
-	** Bug 2672: Some OSes (MacOSX and Linux) don't block spoofed ::1
+	** Classic Bug 2672: Some OSes (MacOSX, Linux) don't block spoofed ::1
 	*/
 
 	if (AF_INET6 == itf->family) {
@@ -2779,9 +2779,9 @@ findlocalinterface(
  *
  * Find the numerically closest local address to the one connect()
  * suggested.  This matches an address on the same subnet first, as
- * needed by Bug 1184, and provides a consistent choice if there are
- * multiple feasible local addresses, regardless of the order ntpd
- * enumerated them.
+ * needed by Classic Bug 1184, and provides a consistent choice if
+ * there are multiple feasible local addresses, regardless of the
+ * order ntpd enumerated them.
  */
 endpt *
 findclosestinterface(


=====================================
ntpd/ntp_peer.c
=====================================
--- a/ntpd/ntp_peer.c
+++ b/ntpd/ntp_peer.c
@@ -602,7 +602,7 @@ refresh_all_peerinterfaces(void)
 	 * or if the one they have hasn't worked for a while.
 	 */
 	for (p = peer_list; p != NULL; p = p->p_link) {
-		if ((p->dstadr) && (p->reach & 0x3))	// Bug 2849 XOR 2043
+		if ((p->dstadr) && (p->reach & 0x3))	// Classic Bug 2849 XOR 2043
 			/* either of last 2 tries with this dstadr worked */
 			continue;
 		if (MDF_POOL & p->cast_flags)


=====================================
ntpd/ntpd.c
=====================================
--- a/ntpd/ntpd.c
+++ b/ntpd/ntpd.c
@@ -1053,7 +1053,7 @@ finish_safe(
 		sig_desc = "";
 	msyslog(LOG_NOTICE, "ERR: %s exiting on signal %d (%s)", progname,
 		sig, sig_desc);
-	/* See Bug 2513 and Bug 2522 re the unlink of PIDFILE */
+	/* See Classic Bugs 2513 and Bug 2522 re the unlink of PIDFILE */
 # if defined(HAVE_DNS_SD_H) && defined(ENABLE_MDNS_REGISTRATION)
 	if (mdns != NULL)
 		DNSServiceRefDeallocate(mdns);


=====================================
ntpd/refclock_oncore.c
=====================================
--- a/ntpd/refclock_oncore.c
+++ b/ntpd/refclock_oncore.c
@@ -2605,7 +2605,7 @@ oncore_msg_Bl(
 
 /*
  * Reg only wants the following output for "deeper" driver debugging.
- * See Bug 2142 and Bug 1866
+ * See Classic Bugs 2142 and Bug 1866
  */
 #if 0
 	oncore_log_f(instance, LOG_DEBUG,
@@ -3373,7 +3373,7 @@ oncore_check_almanac(
 
 		bits3 = instance->BEHa[141];	/* UTC parameters */
 		if (!instance->count5_set && (bits3 & 0xC0)) {
-			instance->count5 = 4;	/* was 2 [Bug 1766] */
+			instance->count5 = 4;	/* was 2 [Classic Bug 1766] */
 			instance->count5_set = 1;
 		}
 #ifdef ONCORE_VERBOSE_CHECK_ALMANAC


=====================================
pylib/packet.py
=====================================
--- a/pylib/packet.py
+++ b/pylib/packet.py
@@ -80,7 +80,7 @@ the client at which the reply was received.  This is not in the reply packet,
 it's the packet receipt time collected by the client.
 
 The 'Reference timestamp' is an unused historical relic.  It's supposed to be
-copied unchanged from upstream in the strutum hierarchy. Normal practice
+copied unchanged from upstream in the stratum hierarchy. Normal practice
 has been for Stratum 1 servers to fill it in with the raw timestamp from the
 most recent reference-clock.
 
@@ -120,7 +120,7 @@ If you look at the raw data, there are 3 unknowns:
    * transit time client to server
    * transit time server to client
    * clock offset
->but there are only two equations, so you can't solve it.
+but there are only two equations, so you can't solve it.
 
 NTP gets a 3rd equation by assuming the transit times are equal.  That lets
 it solve for the clock offset.



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/7e4f35d06ddf76df33e21805f10c4fd00e7292c1

---
View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/7e4f35d06ddf76df33e21805f10c4fd00e7292c1
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/vc/attachments/20170823/a3b26e60/attachment.html>