[Git][NTPsec/ntpsec][master] 2 commits: libisc/error: add two attribute((format)) tags.

[Gary E. Miller]

Gary E. Miller pushed to branch master at NTPsec / ntpsec


Commits:
1154a4ca by Gary E. Miller at 2017-04-24T18:28:56-07:00
libisc/error: add two attribute((format)) tags.

- - - - -
564ad531 by Gary E. Miller at 2017-04-24T18:34:33-07:00
waf: remove -Wmissing-format-attribute

Complains mostly about libisc, false positives.

Only warnings left in --enable-warnings, on my host, are Bison warnings.

- - - - -


2 changed files:

- libisc/error.c
- wafhelpers/configure.py


Changes:

=====================================
libisc/error.c
=====================================
--- a/libisc/error.c
+++ b/libisc/error.c
@@ -25,8 +25,10 @@ default_fatal_callback(const char *, int, const char *, va_list)
      ISC_FORMAT_PRINTF(3, 0);
 
 /*% unexpected_callback */
-static isc_errorcallback_t unexpected_callback = default_unexpected_callback;
-static isc_errorcallback_t fatal_callback = default_fatal_callback;
+static isc_errorcallback_t unexpected_callback ISC_FORMAT_PRINTF(3, 0) \
+	 = default_unexpected_callback;
+static isc_errorcallback_t fatal_callback ISC_FORMAT_PRINTF(3, 0) \
+	 = default_fatal_callback;
 
 void
 isc_error_setunexpected(isc_errorcallback_t cb) {


=====================================
wafhelpers/configure.py
=====================================
--- a/wafhelpers/configure.py
+++ b/wafhelpers/configure.py
@@ -334,7 +334,7 @@ def cmd_configure(ctx, config):
             # "-Waggregate-return",   # breaks ldiv(), ntpcal_daysplit(),  etc.
             # "-Wbad-function-cast",  # ntpd casts long<->double a lot
             # "-Wformat-nonliteral",  # complains about a used feature
-            "-Wmissing-format-attribute",
+            # "-Wmissing-format-attribute", # false positives
             # "-Wnested-externs",     # incompatible w/ Unity...
             # "-Wpadded",             # duck... over 3k warnings
             # "-Wredundant-decls",    # incompatible w/ Unity



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/compare/a78cd73b8cdf44cedd61a0be6a2973e873fd7ffe...564ad5317737111e0ddcbf27f0a2c0f6729184bb

---
View it on GitLab: https://gitlab.com/NTPsec/ntpsec/compare/a78cd73b8cdf44cedd61a0be6a2973e873fd7ffe...564ad5317737111e0ddcbf27f0a2c0f6729184bb
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/vc/attachments/20170425/5a96c62c/attachment.html>