[Git][NTPsec/ntpsec][master] 3 commits: PEP8: E231 missing whitespace after ','

Eric S. Raymond gitlab at mg.gitlab.com
Tue Oct 18 12:11:55 UTC 2016


Eric S. Raymond pushed to branch master at NTPsec / ntpsec


Commits:
2a48ffd2 by Matt Selsky at 2016-10-18T08:11:32-04:00
PEP8: E231 missing whitespace after ','

- - - - -
f60166d8 by Matt Selsky at 2016-10-18T08:11:32-04:00
PEP8: W391 blank line at end of file

- - - - -
73a3fa95 by Matt Selsky at 2016-10-18T08:11:32-04:00
Grammar, typos

- - - - -


11 changed files:

- docs/driver_gpsd.txt
- libparse/wscript
- ntpstats/ntpviz
- pylib/statfiles.py
- pylib/wscript
- util/wscript
- wafhelpers/check_multicast.py
- wafhelpers/check_sizeof.py
- wafhelpers/check_structfield.py
- wafhelpers/configure.py
- wafhelpers/probes.py


Changes:

=====================================
docs/driver_gpsd.txt
=====================================
--- a/docs/driver_gpsd.txt
+++ b/docs/driver_gpsd.txt
@@ -4,7 +4,7 @@
 == Synopsis ==
 
 ["verse",subs="normal"]
-Bame: gpsd
+Name: gpsd
 Reference ID: GPSD
 Serial Port: /dev/gps__u__ 
 
@@ -122,11 +122,11 @@ use IBT alone over not getting synchronised at all.
 This driver can create a lot of syslog messages when things go wrong,
 and cluttering the log files is frowned upon. So we attempt to log
 persistent or recurring errors only once per hour. On the other hand,
-when tracking a problem the syslog flood throttle can get into the way.
+when tracking a problem, the syslog flood throttle can get in the way.
 
 Therefore, option _flag3_ can be used to _disable_ the flood throttle at
 any time; the throttle is engaged by default. Running with the syslog
-flood throttle disabled for lengthy time is not recommended unless the
+flood throttle disabled for extended periods is not recommended unless the
 log files are closely monitored.
 
 
@@ -154,7 +154,7 @@ signal^link:#fn2[2]^. [[fn2bl]] The PPS flag gets cleared if no PPS
 records can be acquired for some time. The unit also flushes the
 sample buffer at this point to avoid the use of stale PPS data.
 
-*Attention:* This unit uses its own PPS fudge value which must be set
+*Attention:* This unit uses its own PPS fudge value, which must be set
 as fudge +time1+. Only the fudge values +time1+ and the +flag1+ option
 have an impact on secondary units.
 


=====================================
libparse/wscript
=====================================
--- a/libparse/wscript
+++ b/libparse/wscript
@@ -30,4 +30,3 @@ def build(ctx):
 		features	= "c cstlib bld_include src_include libisc_include",
 		source		= libparse_source,
 	)
-


=====================================
ntpstats/ntpviz
=====================================
--- a/ntpstats/ntpviz
+++ b/ntpstats/ntpviz
@@ -190,8 +190,8 @@ class VizStats(NTPStats):
         # pretty print the values
         self.percs_f = {}
         for k, v in self.percs.items():
-            self.percs[k]   = round(v,3)
-            self.percs_f[k] = format(v,",.3f")
+            self.percs[k]   = round(v, 3)
+            self.percs_f[k] = format(v, ",.3f")
 
         # Python is stupid about nested objects, so add in some other stuff
         self.percs_f["multiplier"] = self.percs["multiplier"] = self.multiplier
@@ -275,7 +275,7 @@ def gnuplot(template, outfile=None):
     v = sys.version_info
     if 3 <= v[0]:
         # next line works in Python 3, not Python 2
-        proc.stdin.write(template.encode('ascii','ignore'))
+        proc.stdin.write(template.encode('ascii', 'ignore'))
     else:
         # next line works in Python 2, not Python 3
         proc.stdin.write(template)


=====================================
pylib/statfiles.py
=====================================
--- a/pylib/statfiles.py
+++ b/pylib/statfiles.py
@@ -108,7 +108,7 @@ class NTPStats:
                 # Morph first field into Unix time with fractional seconds
                 for line in lines:
                     line = line.strip(' \0\r\n\t')
-                    line = NTPStats.unixize(line,starttime, endtime)
+                    line = NTPStats.unixize(line, starttime, endtime)
                     if line is not None:
                         lines1.append( line)
 


=====================================
pylib/wscript
=====================================
--- a/pylib/wscript
+++ b/pylib/wscript
@@ -3,7 +3,7 @@ def options(opt):
 
 def configure(conf):
     conf.load('python')
-    conf.check_python_version((2,6,0))
+    conf.check_python_version((2, 6, 0))
 
 def build(ctx):
     srcnode = ctx.srcnode.make_node('pylib')
@@ -17,4 +17,4 @@ def build(ctx):
 	target      = target,
 	)
 
-    ctx(features='py', source=ctx.path.ant_glob('*.py'), install_from='.',install_path='${PYTHONDIR}/ntp')
+    ctx(features='py', source=ctx.path.ant_glob('*.py'), install_from='.', install_path='${PYTHONDIR}/ntp')


=====================================
util/wscript
=====================================
--- a/util/wscript
+++ b/util/wscript
@@ -16,4 +16,3 @@ def build(ctx):
 			use		= "ntp opts isc M RT THR PTHREAD",
 			install_path    = None,
 		)
-


=====================================
wafhelpers/check_multicast.py
=====================================
--- a/wafhelpers/check_multicast.py
+++ b/wafhelpers/check_multicast.py
@@ -16,4 +16,3 @@ int main() {
                 msg = "Checking for multicast capability",
                 mandatory = False,
                 comment = "IP multicast capability")
-


=====================================
wafhelpers/check_sizeof.py
=====================================
--- a/wafhelpers/check_sizeof.py
+++ b/wafhelpers/check_sizeof.py
@@ -56,7 +56,7 @@ def check_sizeof_cross(ctx, header, sizeof, mandatory=True):
 	else:
 		ctx.start_msg("Checking sizeof %s" % (sizeof))
 
-	for size in range(2,13):
+	for size in range(2, 13):
 
 		try:
 			ctx.check_cc(


=====================================
wafhelpers/check_structfield.py
=====================================
--- a/wafhelpers/check_structfield.py
+++ b/wafhelpers/check_structfield.py
@@ -14,7 +14,7 @@ int main () {
 
 @conf
 def check_structfield(ctx, fld, type, hdrs, mandatory=False):
-        name = "STRUCT_%s_HAS_%s" % (type.upper(), fld.upper().replace('.','_'))
+        name = "STRUCT_%s_HAS_%s" % (type.upper(), fld.upper().replace('.', '_'))
         src = ""
         for hdr in hdrs:
                 src += "#include <%s>\n" % hdr


=====================================
wafhelpers/configure.py
=====================================
--- a/wafhelpers/configure.py
+++ b/wafhelpers/configure.py
@@ -340,10 +340,10 @@ def cmd_configure(ctx, config):
                 "linux/serial.h",
                 ("md5.h", ["sys/types.h"]),
                 "net/if6.h",
-                ("net/route.h", ["sys/types.h","sys/socket.h","net/if.h"]),
+                ("net/route.h", ["sys/types.h", "sys/socket.h", "net/if.h"]),
                 "netinfo/ni.h",         # Apple
                 "priv.h",               # Solaris
-                ("resolv.h", ["sys/types.h","netinet/in.h","arpa/nameser.h"]),
+                ("resolv.h", ["sys/types.h", "netinet/in.h", "arpa/nameser.h"]),
                 "semaphore.h",
                 "stdatomic.h",
                 "sys/clockctl.h",       # NetBSD
@@ -359,8 +359,8 @@ def cmd_configure(ctx, config):
         if not ctx.options.disable_lineeditlibs:
                 optional_headers += (
                         "histedit.h",   # Apple
-                        ("readline/readline.h",["stdio.h"]),
-                        ("readline/history.h", ["stdio.h","readline/readline.h"]),
+                        ("readline/readline.h", ["stdio.h"]),
+                        ("readline/history.h", ["stdio.h", "readline/readline.h"]),
                 )
         for hdr in optional_headers:
                 if isinstance(hdr, str):


=====================================
wafhelpers/probes.py
=====================================
--- a/wafhelpers/probes.py
+++ b/wafhelpers/probes.py
@@ -9,7 +9,7 @@ def probe_header_with_prerequisites(ctx, header, prerequisites, use=None):
         for hdr in prerequisites + [header]:
                 src += "#include <%s>\n" % hdr
         src += "int main() { return 0; }\n"
-        have_name = "HAVE_%s" % header.replace(".","_").replace("/","_").upper()
+        have_name = "HAVE_%s" % header.replace(".", "_").replace("/", "_").upper()
         ctx.check_cc(
                 fragment=src,
                 define_name=have_name,
@@ -40,5 +40,3 @@ def probe_function_with_prerequisites(ctx, function, prerequisites, use=None):
         return ctx.get_define(have_name)
 
 # end
-
-



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/compare/a2ef2b6989e0107f507ccf2a18786e755b20198b...73a3fa95743f2e0a24031c23691bda0e4616e180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ntpsec.org/pipermail/vc/attachments/20161018/28bbc8ac/attachment.html>


More information about the vc mailing list