[Git][NTPsec/ntpsec][master] Remove remnants of old workaround for the mlockall/threads/async-DNS bug.

[Eric S. Raymond]

Eric S. Raymond pushed to branch master at NTPsec / ntpsec


Commits:
80983d15 by Eric S. Raymond at 2016-07-06T21:30:00-04:00
Remove remnants of old workaround for the mlockall/threads/async-DNS bug.

- - - - -


1 changed file:

- ntpd/wscript


Changes:

=====================================
ntpd/wscript
=====================================
--- a/ntpd/wscript
+++ b/ntpd/wscript
@@ -128,18 +128,12 @@ def build(ctx):
 		refclock_define = ["REFCLOCK=1"]
 
 
-	# Note carefully: At least as of September 2015 you must link with 
-	# libgcc_s.so under Linux, otherwise the threaded getaddrinfo(3) call
-	# used to look up hostnames will SIGABRT and take ntpd down with it.
-	# That may only happen when mlockall() is used with not-enough-memory,
-	# but it has caused a long legacy of hard to diagnose problems.
-
 	ctx(
 		target		= "ntpd",
 		features	= "c rtems_trace cprogram bld_include src_include libisc_include libisc_pthread_include ntp_version",
 		source		= ntpd_source,
-		use			= "libntpd_obj isc ntp sodium opts OSSAUDIO M parse GCC_S RT CAP THR PTHREAD CRYPTO DNS_SD DNS_SD_INCLUDES %s" % use_refclock,
-#		use			= "libntpd_obj bison_obj isc ntp sodium opts OSSAUDIO M parse GCC_S RT CAP THR PTHREAD CRYPTO DNS_SD DNS_SD_INCLUDES %s" % use_refclock,
+		use			= "libntpd_obj isc ntp sodium opts OSSAUDIO M parse RT CAP THR PTHREAD CRYPTO DNS_SD DNS_SD_INCLUDES %s" % use_refclock,
+#		use			= "libntpd_obj bison_obj isc ntp sodium opts OSSAUDIO M parse RT CAP THR PTHREAD CRYPTO DNS_SD DNS_SD_INCLUDES %s" % use_refclock,
 		includes	= [
 						"%s/host/ntpd/" % ctx.bldnode.parent.abspath(),
 						"%s/ntpd/" % srcnode,
@@ -163,7 +157,7 @@ def build(ctx):
 			features	= "c cprogram bld_include src_include libisc_include libisc_pthread_include ntp_version",
 			source		= ntpdsim_source,
 			defines		= ["SIM"],
-			use		= "libntpd_obj bison_obj isc ntp opts M parse GCC_S RT CAP THR PTHREAD CRYPTO DNS_SD DNS_SD_INCLUDES %s" % use_refclock,
+			use		= "libntpd_obj bison_obj isc ntp opts M parse RT CAP THR PTHREAD CRYPTO DNS_SD DNS_SD_INCLUDES %s" % use_refclock,
 			includes	= [
 							"%s/ntpd/" % bldnode,
 							"%s/ntpd/" % srcnode



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/80983d153157ff0502ede5c078d40b03f77bbbf3
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ntpsec.org/pipermail/vc/attachments/20160707/137aa987/attachment.html>