[Git][NTPsec/ntpsec][master] Add comments for USE_WORKER

[Hal Murray]

Hal Murray pushed to branch master at NTPsec / ntpsec


Commits:
6331eb58 by Hal Murray at 2016-08-21T03:15:10-07:00
Add comments for USE_WORKER

- - - - -


2 changed files:

- BUGS
- devel/ifdex-ignores


Changes:

=====================================
BUGS
=====================================
--- a/BUGS
+++ b/BUGS
@@ -1,5 +1,15 @@
 = Known bugs =
 
+* The current setup assumed pthreads.  They are only used for DNS
+  lookups.  It looks like most of the code is setup to do the right
+  thing, but include/ntp_workimpl.h unconditionally turns on USE_WORKER
+
+  waf sets up HAVE_PTHREAD and HAVE_PTHREAD_H, but none of the code
+  uses them.
+
+  USE_WORKER should probably be renamed to USE_DNS or USE_DNS_WORKER
+
+
 * msyslog doesn't have its own mutex.  Non-atomicity can cause scrambled
   logs in some cases involving asynchronous getaddrinfo lookups.
 


=====================================
devel/ifdex-ignores
=====================================
--- a/devel/ifdex-ignores
+++ b/devel/ifdex-ignores
@@ -155,6 +155,11 @@ USE_SCM_TIMESTAMPNS	# "
 # alternate way to get time stamps, never set
 ENABLE_SIGNALED_IO	# Use SIGIO for asynchronous I/O notification
 
+USE_WORKER		# Asynchronous DNS available, needs pthreads
+USE_WORK_PIPE		# Set in ntp_workimpl.h
+USE_WORK_THREAD
+
+
 USE_IPV6_SUPPORT
 USE_IPV6_MULTICAST_SUPPORT
 USE_LE_EDITLINE
@@ -165,9 +170,6 @@ USE_LIFC_FLAGS
 USE_PCM_STYLE_SOUND
 USE_ROUTING_SOCKET
 USE_TSF_USEC_TABLES
-USE_WORK_PIPE
-USE_WORK_THREAD
-USE_WORKER
 YY_YY_NTP_PARSER_TAB_H_INCLUDED
 calloc			# In Unity
 close			# In Windows port config



View it on GitLab: https://gitlab.com/NTPsec/ntpsec/commit/6331eb58d98abc342f429db49d0c077bbdcd2cd6
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ntpsec.org/pipermail/vc/attachments/20160821/913c488f/attachment.html>