<div dir="ltr"><div class="inbox-inbox-uyb8Gf" style="color:rgb(33,33,33)"><div><div class="inbox-inbox-pv" style="color:rgb(117,117,117)">>> The code for freeing up key strings zeros them out first. How do we do that in python or go?<br>> <span style="color:rgb(33,33,33)">Same way you would in C, iterate over them writing zeros. Am I </span><span style="color:rgb(33,33,33)">missing something?</span></div></div></div><div class="inbox-inbox-uyb8Gf" style="color:rgb(33,33,33)"><div class="inbox-inbox-F3hlO"><br></div><div class="inbox-inbox-F3hlO">I may be not understanding something.</div><div class="inbox-inbox-F3hlO">I thought that strings were non-mutatable in Python, and every time one is written to, the interpreter actually allocates a new string and eventually GCs the old value.</div><div class="inbox-inbox-F3hlO"><br></div><div class="inbox-inbox-F3hlO">..m</div><div class="inbox-inbox-F3hlO"><br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jun 6, 2018 at 4:35 AM Eric S. Raymond via devel <<a href="mailto:devel@ntpsec.org">devel@ntpsec.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hal Murray via devel <<a href="mailto:devel@ntpsec.org" target="_blank">devel@ntpsec.org</a>>: <br>
> I occasionally add msyslog lines when debugging. The DPRINTF stuff isn't <br>
> interesting - too much junk I don't want. When I'm cleaning up, should I <br>
> disable them with "if (0)", or delete them? Is there a better way? ...<br>
<br>
What I do is delete them unless I think they might have continuing value,<br>
in which case I put them under DPRINTF.<br>
<br>
> Some/many of the prototypes in our header files are not very useful. I think the problem is the lack of names on the parameters. If the types are all different, that's enough, but if there are several integer parameters that doesn't help. Here is an example:<br>
> extern int clocktime (int, int, int, int, int, time_t, uint32_t, uint32_t *, uint32_t *);<br>
<br>
Fair point. Are you advocating outting the formal names back in?<br>
<br>
> There is still some broadcast/multicast stuff around. grep for CAST will find them. Should we leave enough around so that our ntpq can decode things when talking to old servers? If so, I vote we move them to ntpclients/<br>
<br>
I agree with moving them to ntpclients. Anything that reeduces the amount of<br>
ceuft ubthe ntpd code is good.<br>
<br>
> Some of the counters that ntpq can display get written to a log file every hour. That resets the counters so ntpq can only see what has happened since then rather than the totals since startup. We should probably maintain and display both.<br>
<br>
Reasonable. Would you make ntpq parse the logfile?<br>
<br>
> It would be nice if ntpq would show something if a server is using authentication. I'd be willing to steal a character from the name column.<br>
<br>
No need. Just boldface the ones with authentication.<br>
<br>
> The code for freeing up key strings zeros them out first. How do we do that in python or go?<br>
<br>
Same way you would in C, iterate over them writing zeros. Am I<br>
missing something?<br>
-- <br>
<a href="<a href="http://www.catb.org/~esr/" rel="noreferrer" target="_blank">http://www.catb.org/~esr/</a>">Eric S. Raymond</a><br>
<br>
My work is funded by the Internet Civil Engineering Institute: <a href="https://icei.org" rel="noreferrer" target="_blank">https://icei.org</a><br>
Please visit their site and donate: the civilization you save might be your own.<br>
<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@ntpsec.org" target="_blank">devel@ntpsec.org</a><br>
<a href="http://lists.ntpsec.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ntpsec.org/mailman/listinfo/devel</a><br>
</blockquote></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><p dir="ltr">Mark Atwood<br>
<a href="http://about.me/markatwood">http://about.me/markatwood</a><br>
+1-206-604-2198</p>
</div></div>