ntpd/ntpq tangle

Hal Murray halmurray at sonic.net
Sat Jul 11 07:43:25 UTC 2026


Thanks.

There is a similar test several lines above.  Does that need the same test?

Do you want to file an MR for this?  Or should I include it with my fix for
ntp_control.c?

------

> Ah, but what if (rhetorically) it's some ridiculous value like AF_VSOCK?

> -               if (AF_UNSPEC == AF(&p->srcadr))
> +              if ((AF_INET != AF(&p->srcadr)) && (AF_INET6 != AF(&p->srcadr))) {

I think AF_UNSPEC is the cleaner test.  It means uninitialized, and will 
still work if we start using AF_VSOCK or whatever as long as we have 
updated socktoa() to handle the new case(s).



-- 
These are my opinions.  I hate spam.





More information about the devel mailing list