Is it time to --enable-warnings?

[Gary E. Miller]

Yo Hal!

On Sat, 08 Feb 2025 21:55:17 -0800
Hal Murray via devel <devel at ntpsec.org> wrote:

> waf configure --help says:
>       --enable-warnings   Enable annoying CC warnings
> 
> Are they really annoying?  My normal build script turns it on without 
> problems.

Ditto for me.

> What does gitlab do with warnings?

Nothing, just logs them.

> Should we be running with -Werror
> to turn warnings into errors so gitlab/CI will notice?  Any reason
> not to do that?

Try it and see.  If the makes the CI look terrible, turn it back off.

> ./wafhelpers/check_strerror.py says:
>    # This uses -Werror which may not be portable.
> Has anybody noticed any problems?

Depends on how you define "problem".  I see that as "opportunity".

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin