From halmurray at sonic.net Fri Aug 1 09:14:24 2025 From: halmurray at sonic.net (Hal Murray) Date: Fri, 01 Aug 2025 02:14:24 -0700 Subject: waf: compiler flags, uninitalized variable In-Reply-To: Message from Fred Wright via devel of "Wed, 30 Jul 2025 10:40:05 -0700." <6963e6f9-607d-3b30-4fde-b6e8bfdd8252@fwright.net> Message-ID: <20250801091424.7CFBF620170@107-137-68-211.lightspeed.sntcca.sbcglobal.net> devel at ntpsec.org said: > Usually, you won't get that type of warning unless you enable it. And > usually, you only get that type of warning in an optimized compile, since > the dataflow analysis needed to detect it is part of the optimization > code. I tried O3. That found a different maybe-uninitialized. I tried O6. Nothing new. -- These are my opinions. I hate spam. From fw at fwright.net Fri Aug 1 14:40:27 2025 From: fw at fwright.net (Fred Wright) Date: Fri, 1 Aug 2025 07:40:27 -0700 (PDT) Subject: waf: compiler flags, uninitalized variable In-Reply-To: <20250801091424.7CFBF620170@107-137-68-211.lightspeed.sntcca.sbcglobal.net> References: <20250801091424.7CFBF620170@107-137-68-211.lightspeed.sntcca.sbcglobal.net> Message-ID: On Fri, 1 Aug 2025, Hal Murray wrote: > devel at ntpsec.org said: >> Usually, you won't get that type of warning unless you enable it. And >> usually, you only get that type of warning in an optimized compile, since >> the dataflow analysis needed to detect it is part of the optimization >> code. > > I tried O3. That found a different maybe-uninitialized. > > I tried O6. Nothing new. The other thing I forgot to mention is that sometimes the control-flow analysis isn't as good in older compilers, leading to complaints about something being used uninitialized in a case where the code couldn't actually be reached in the unininitialized case. Unless there's a good reason to avoid it, usually the best fix is just to add an initializer to the declaration, even if it's not logically necessary. Fred Wright From halmurray at sonic.net Fri Aug 1 18:54:32 2025 From: halmurray at sonic.net (Hal Murray) Date: Fri, 01 Aug 2025 11:54:32 -0700 Subject: waf: compiler flags, uninitalized variable In-Reply-To: Message from Fred Wright via devel of "Fri, 01 Aug 2025 07:40:27 -0700." Message-ID: <20250801185432.18146620170@107-137-68-211.lightspeed.sntcca.sbcglobal.net> > The other thing I forgot to mention is that sometimes the control-flow > analysis isn't as good in older compilers, leading to complaints about > something being used uninitialized in a case where the code couldn't > actually be reached in the unininitialized case. Unless there's a good > reason to avoid it, usually the best fix is just to add an initializer to > the declaration, even if it's not logically necessary. I usually add a "keep compiler happy" comment to that sort of code. If I see that sort of code without a comment, I looking for it. The example that started this thread was really simple. -- These are my opinions. I hate spam. From halmurray at sonic.net Fri Aug 1 19:03:09 2025 From: halmurray at sonic.net (Hal Murray) Date: Fri, 01 Aug 2025 12:03:09 -0700 Subject: waf: compiler flags, uninitalized variable In-Reply-To: Message from Hal Murray of "Fri, 01 Aug 2025 11:54:32 -0700." <20250801185432.18146620170@107-137-68-211.lightspeed.sntcca.sbcglobal.net> Message-ID: <20250801190309.95F32620170@107-137-68-211.lightspeed.sntcca.sbcglobal.net> > If I see that sort of code without a comment, I looking for it. Looks like I fatfingered something. That should have been: If I see that sort of code without a comment, I get suspicious wondering if there might be something tricky going on and waste time looking for it. -- These are my opinions. I hate spam. From halmurray at sonic.net Sat Aug 23 23:03:09 2025 From: halmurray at sonic.net (Hal Murray) Date: Sat, 23 Aug 2025 16:03:09 -0700 Subject: CI broken -- macos post install checks can't find Python NTP library Message-ID: <20250823230309.BFDD962003D@107-137-68-211.lightspeed.sntcca.sbcglobal.net> It looks like it needa a pth file, but I don't know what version of Python it is using. Is there a simple way to find out? -- These are my opinions. I hate spam. From halmurray at sonic.net Sat Aug 23 23:38:12 2025 From: halmurray at sonic.net (Hal Murray) Date: Sat, 23 Aug 2025 16:38:12 -0700 Subject: Anybody using the HPGOS driver? With Z3801A? Message-ID: <20250823233812.0ED7C62003D@107-137-68-211.lightspeed.sntcca.sbcglobal.net> My Z3801A got hit by a WNRO glitch last weekend. Time jumped back to 2006 Jan 01. If you are using a Z3801A that didn't jump back in time, what version are you running? There should be something like this HEWLETT-PACKARD,Z3801A,3542A04389,3543-A in your clockstats (from when the driver was last started). I just pushed a fix -- copied from the NMEA driver. That push included my collected fixes/tweaks to the driver. The main ones are: Dropping the scpi > from clockstats optional logging of some device internals It's been well tested on the Z3801A but I might have broken something on some other devices. -- These are my opinions. I hate spam. From jamesb192 at jamesb192.com Sat Aug 23 23:55:33 2025 From: jamesb192 at jamesb192.com (James Browning) Date: Sat, 23 Aug 2025 16:55:33 -0700 Subject: CI broken -- macos post install checks can't find Python NTP library In-Reply-To: <20250823230309.BFDD962003D@107-137-68-211.lightspeed.sntcca.sbcglobal.net> References: <20250823230309.BFDD962003D@107-137-68-211.lightspeed.sntcca.sbcglobal.net> Message-ID: <3982463.lGaqSPkdTl@bourbon2.jamesb192.com> On Saturday, August 23, 2025 4:03:09?PM Pacific Daylight Time Hal Murray via devel wrote: > It looks like it needa a pth file, but I don't know what version of Python > it is using. > > Is there a simple way to find out? Yes, according to lines 140-141 of some rando file[1] it is Python 3.12.7. I having last touched the CI files, am to blame. Lines 403-405 and 408 need to go, unless post DESTDIR install checks get gaped ``` Checking for program 'python' : /Users/gitlab/.asdf/installs/python/ 3.12.7/bin/python Checking for python version >= 2.7.0 : 3.12.7 ``` [1] https://gitlab.com/NTPsec/ntpsec/-/jobs/11116878714