Time for a release?

James Browning jamesb192 at jamesb192.com
Tue Oct 31 15:00:01 UTC 2023


> On 10/31/2023 2:28 AM PDT Hal Murray via devel <devel at ntpsec.org> wrote:
> 
> > Here are the open issues the caught my eye:
> > https://gitlab.com/NTPsec/ntpsec/-/issues/806
> 
> I think we should fix that.  Or at least try.  It sounds like a bug in 
> ntp_control.  I just tried rv xxx for some xxx that was a reasonable assid.  
> It didn't print any garbage.  Anybody got a handy test case?
> 
> Looking at the code...
> It fills a buffer with 8 " %.2f", then calls the routine that prints that as 
> name=value.
> That won't work with spaces in there -- well, maybe it will, but it depends on 
> what the parser in ntpq does.  I'd expect it to call the routine that prints 
> it as name="value".  But I don't know what ntpq is doing...  We should print 
> that stuff in a nice table.

It was an issue in 1.2.1 and 1.2.2, Hal solved it already. A slightly
longer overview is in #806. The short version is I forgot to
initialize the first byte of storage and whatever cruft was in there
up to the first NUL got in.


More information about the devel mailing list