ntpsec | solve #714, #737 by removing ill-conceived test. (!1270)

jamesb192@jamesb192.com jamesb192@jamesb192.com jamesb192 at jamesb192.com
Sun May 15 02:29:14 UTC 2022


> On 05/14/2022 8:42 PM Hal Murray via devel <devel at ntpsec.org> wrote:
> 
>  
> I'm cc-ing devel so this doesn't get lost on gitlab.  Let's move the 
> discussion real email..
> 
> 
> > include/ntp_fp.h:58 defines l_fp as a uint64_4, I can find no current contrary definitions.
> 
> We need to make a cleanup pass in this area.
> 
> On the wire, it's unsigned.  As soon as the code gets 2 of them, it does a 
> subtract so we need a signed version.  We need to check for underflow on the 
> initial subtract.
> 
> There is also u_fp, a 32 bit version.  The comment says there is a s_fp, but I 
> can't find it.

There used to be 45 back around git-conversion, they have gone extinct since.

> -------
> 
> I think we should comment out this test until we get the release out.
> Please include references to both issues and this message/thread.


More information about the devel mailing list