ntpsec | solve #714, #737 by removing ill-conceived test. (!1270)

[Gary E. Miller]

Yo Hal!

On Sat, 14 May 2022 17:42:59 -0700
Hal Murray via devel <devel at ntpsec.org> wrote:

> I'm cc-ing devel so this doesn't get lost on gitlab.  Let's move the 
> discussion real email..
> 
> 
> > include/ntp_fp.h:58 defines l_fp as a uint64_4, I can find no
> > current contrary definitions.  
> 
> We need to make a cleanup pass in this area.
> 
> On the wire, it's unsigned.  As soon as the code gets 2 of them, it
> does a subtract so we need a signed version.  We need to check for
> underflow on the initial subtract.
> 
> There is also u_fp, a 32 bit version.  The comment says there is a
> s_fp, but I can't find it.
> 
> -------
> 
> I think we should comment out this test until we get the release out.
> Please include references to both issues and this message/thread.

I'm OK with commenting it out, just the two lines, until we figure out
what clang is doing.  But I'd rather figure it out...

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20220514/1b5522e9/attachment.bin>