We need to test leap smearing :)

Hal Murray halmurray at sonic.net
Wed Dec 21 23:26:08 UTC 2022


Does anybody use it?
Do any distros build with it enabled?
Should we add an "#warn untested" to the code?


static void
leap_smear_add_offs(l_fp *t) {
        t += leap_smear.offset;
}

clang 13 points out:
../../ntpd/ntp_proto.c:2210:27: warning: parameter 't' set but not used 
[-Wunused-but-set-parameter]

[If you don't see the bug right away, look harder.]

My normal testing doesn't include smearing.
This is tickled by option-tester which includes --enable-leap-smear


-- 
These are my opinions.  I hate spam.





More information about the devel mailing list