Release, wildcards, etc
Hal Murray
halmurray at sonic.net
Thu Apr 21 08:17:11 UTC 2022
[Eric: There are a couple of preceding messages to devel in the mail
someplace.]
> I'd like to get https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1264 merged
> and then do the release.
> Is there anything else that we want in the release?
I'm sorry that we have gotten off on the wrong foot (feet?).
I'll try to review and maybe fill in a few blanks.
It's time for a release in general. Fixing the wildcard bug is a good excuse
to do it now. There is no rush or deadline.
You are putting me in an awkward position by asking me to approve your patch
when I want to do something else. I think your fix will do what you want. I
haven't actually tested it.
You have a simple fix for the wildcards. I have a more complicated one, with
knobs that you don't like. If it wasn't for tangling with your fix, I would
have just pushed this code.
I'm not sure why you don't like my knobs. Several possibilities:
1) more code to test.
There are 8 cases. I think I tested them all. If it will make you happy,
I'll test again, being careful to check all 8 cases.
2) it's useless clutter
I'd like to experiment with it. Other than general clutter, I can't think
of any reason not to include my knobs.
3) you want to get the release out soon and don't want to think about knobs.
As far as I know, there is no rush on the release.
I'll help more with testing if my knobs are in.
4) others?
--------
I can't think of anything else that needs to go into this release.
I have some code that adds another line to the (already noisy) client side
logging for the KE exchange to display the SAN:DNS list from the certificate.
I think it should go in, but I'll wait until after the release if you prefer.
We should scan the issues and merge requests. (James has several that we have
all been negligent about approving or providing feedback.)
--
These are my opinions. I hate spam.
More information about the devel
mailing list