--enable-doc waf config option removed

[Richard Laager]

We discussed this in #ntpsec. For context, I wasn't the original MR
author, but I was very involved in review of the MR, approved it, and
ultimately merged it.


My understanding is that there are two objections here:

1) Changing the default was mixed in with other changes.

2) It is undesirable to require changes to existing build scripts (e.g.
   in distro packages). Specifically for this change, that would be
   those which:
     A) use --enable-doc, or
     B) don't have asciidoc and don't use --disable-manapage

I'm confident that a solution is close at hand. Skip to the MR link
below if you like.


My thoughts on the first point:

"I agree ... in general that things should be separated out. But in
practice, these things were relatively interlinked. It's not that it
couldn't be separated out, but it would have been more work. JamesB192
put a lot of work into this already, and it was barely getting the
attention it needed. I certainly didn't want to force him to split it up
given that nobody seemed to care about the policy change.

"In the future, I can certainly put more weight on the side of splitting
things up."


On the second point:

I didn't see this as a big problem, and *I* am a distro packager, but I
certainly have no problem taking steps to address it. I initially
suggested that we accept --enable-doc as a no-op for backwards
compatibility. I also suggested an alternative of accepting both
--enable-* and --disable-*. Eric seemed happy with either. After further
investigation, I ultimately implemented the latter:

https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1095

This gives us almost all of the advantages of both the before and after
states. The only thing we miss out on is that if you don't have
asciidoc(tor), you will not get the docs / man pages. This was the
behavior before and is either a feature or a bug, depending on your
point-of-view.

-- 
Richard

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20200203/0f47f6ec/attachment.bin>